8 Commits

Author SHA1 Message Date
Your Name a64f1184cd feat: add star sparkle brush preset and enhance star brush parameters
mandatory-regression-gate / deterministic-tests (push) Waiting to run
mandatory-regression-gate / protected-performance-path (push) Waiting to run
2026-07-26 03:50:02 +03:00
Your Name acd7de5dd3 Merge branch 'Art-media-checkered-pattern-analysis'
mandatory-regression-gate / deterministic-tests (push) Waiting to run
mandatory-regression-gate / protected-performance-path (push) Waiting to run
2026-07-25 22:57:03 +03:00
Your Name cea60143b1 feat: enhance star brush with sparkle effect and update UI label
mandatory-regression-gate / deterministic-tests (push) Waiting to run
mandatory-regression-gate / protected-performance-path (push) Waiting to run
2026-07-25 22:56:14 +03:00
Your Name fd205309b6 fix: resolve checkerboard artifact in brush strokes and update AGENTS.md for v3.05
mandatory-regression-gate / deterministic-tests (push) Waiting to run
mandatory-regression-gate / protected-performance-path (push) Waiting to run
2026-07-25 20:39:13 +03:00
Your Name 19a7e51813 feat: add cyclic color and speed options for brush settings
mandatory-regression-gate / deterministic-tests (push) Waiting to run
mandatory-regression-gate / protected-performance-path (push) Waiting to run
2026-07-25 17:34:41 +03:00
Your Name 683dac06ec refactor: improve code readability by formatting and restructuring function parameters and logic
mandatory-regression-gate / deterministic-tests (push) Waiting to run
mandatory-regression-gate / protected-performance-path (push) Waiting to run
2026-07-25 16:56:28 +03:00
Your Name 45a231a456 feat: allow brush strokes to extend beyond canvas edges in viewport and shader calculations
mandatory-regression-gate / deterministic-tests (push) Waiting to run
mandatory-regression-gate / protected-performance-path (push) Waiting to run
2026-07-25 16:34:51 +03:00
Your Name eb17bf4205 feat: implement compact layout and real-time preview for Brushes & Tips panel
mandatory-regression-gate / deterministic-tests (push) Waiting to run
mandatory-regression-gate / protected-performance-path (push) Waiting to run
- Introduced a more compact layout for the Brushes & Tips panel in the Iced GUI.
- Added a real-time brush-tip preview that updates based on current brush parameters and foreground color.
- Adjusted thumbnail sizes and grid layout to improve usability and visual clarity.
- Implemented caching for live previews to optimize performance.
- Updated existing code to integrate new layout and preview functionalities.
- Ensured no changes were made to engine crates, maintaining stability.
2026-07-25 16:28:31 +03:00
15 changed files with 1757 additions and 384 deletions
@@ -0,0 +1,263 @@
# Iced Brushes Panel — Compact Layout + Real-Time Preview
## Goal
Make the `hcie-iced-app` Brushes & Tips panel more compact and add a real-time brush-tip preview that reacts to current brush parameters and foreground color.
**Scope is limited to the Iced GUI layer.** Engine crates stay locked and untouched; all rendering goes through the public `hcie_engine_api` surface.
---
## Context
- Active target workspace (per user override): `hcie-iced-app/`.
- Primary file: `hcie-iced-app/crates/hcie-iced-gui/src/panels/brushes.rs`.
- Panel wiring: `hcie-iced-app/crates/hcie-iced-gui/src/dock/view.rs` calls `crate::panels::brushes::view(...)`.
- Current layout:
- Category tabs with 16 px SVG icons.
- Thumbnail image 48 px inside a 56 px cell.
- Two-column grid with 4 px spacing.
- Label text size 9 px.
- A bottom "Preview" area using a static style-keyed 64 px image.
- Available engine APIs (already public in `hcie_engine_api`):
- `Engine::render_brush_stamp_preview(width, height, &BrushTip, color)` — fast single-dab preview.
- `Engine::render_brush_preview(width, height, &BrushTip, color, &points)` — full stroke preview.
---
## Decisions
| Decision | Choice |
|----------|--------|
| Preview API | `Engine::render_brush_stamp_preview` (fast, parameter-aware). |
| Thumbnail image size | 36 px. |
| Thumbnail cell size | 40 px. |
| Grid columns | 3. |
| Label text | 8 px, kept. |
| Grid/item spacing | 3 px. |
| Tab icon size | Keep 16 px (already compact). |
| Live preview color | Current foreground color `fg_color`. |
| Cache key | `(style, size_byte, hardness_byte, opacity_byte, fg_color)` so the preview updates when parameters change. |
| Watercolor preset thumbnails | Keep current splat renderer but shrink to 36 px image / 40 px cell and align with the new grid. |
| Imported preset thumbnails | Keep list row style but shrink preview to 36 px image in 40 px cell. |
---
## Implementation Steps
### 1. Add foreground color to panel signature
In `hcie-iced-app/crates/hcie-iced-gui/src/dock/view.rs`, pass `app.fg_color` into `brushes::view(...)`.
In `hcie-iced-app/crates/hcie-iced-gui/src/panels/brushes.rs`, extend the function signature:
```rust
pub fn view(
current_style: BrushStyle,
current_size: f32,
current_opacity: f32,
current_hardness: f32,
brush_color_variant: bool,
brush_variant_amount: f32,
active_category: BrushCategory,
imported_presets: &[hcie_engine_api::BrushPreset],
active_brush_preset: Option<&hcie_engine_api::BrushPreset>,
fg_color: [u8; 4], // NEW
colors: ThemeColors,
) -> Element<'static, Message>
```
### 2. Introduce compact layout constants
At the top of `brushes.rs`, replace/adjust constants:
```rust
const THUMB_SIZE: u32 = 40;
const PREVIEW_IMG_SIZE: u32 = 36;
const GRID_COLUMNS: usize = 3;
const GRID_SPACING: u16 = 3;
const ITEM_SPACING: u16 = 3;
const LABEL_SIZE: u16 = 8;
```
Also add a real-time preview cache keyed by parameters:
```rust
static LIVE_PREVIEW_CACHE: OnceLock<Mutex<HashMap<PreviewKey, iced::widget::image::Handle>>> = OnceLock::new();
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
struct PreviewKey {
style_idx: usize,
size: u8, // quantized to whole px
hardness: u8, // 0..100
opacity: u8, // 0..100
r: u8,
g: u8,
b: u8,
a: u8,
}
```
### 3. Build a parameter-aware preview generator
Add a helper that constructs a `BrushTip` from the current tool state and calls `Engine::render_brush_stamp_preview`:
```rust
fn build_tip_from_state(style: BrushStyle, size: f32, opacity: f32, hardness: f32) -> hcie_engine_api::BrushTip {
hcie_engine_api::BrushTip {
style,
size,
opacity,
hardness,
..Default::default()
}
}
```
Add:
```rust
fn get_live_stamp_preview(
style: BrushStyle,
size: f32,
opacity: f32,
hardness: f32,
fg_color: [u8; 4],
) -> iced::widget::image::Handle {
let key = PreviewKey {
style_idx: style as usize,
size: size.clamp(1.0, 255.0) as u8,
hardness: (hardness * 100.0).clamp(0.0, 100.0) as u8,
opacity: (opacity * 100.0).clamp(0.0, 100.0) as u8,
r: fg_color[0],
g: fg_color[1],
b: fg_color[2],
a: fg_color[3],
};
let cache = LIVE_PREVIEW_CACHE.get_or_init(|| Mutex::new(HashMap::new()));
let mut cache = cache.lock().unwrap_or_else(|p| p.into_inner());
if let Some(handle) = cache.get(&key) {
return handle.clone();
}
let tip = build_tip_from_state(style, size, opacity, hardness);
let pixels = hcie_engine_api::Engine::render_brush_stamp_preview(
PREVIEW_IMG_SIZE,
PREVIEW_IMG_SIZE,
&tip,
fg_color,
);
let handle = iced::widget::image::Handle::from_rgba(
PREVIEW_IMG_SIZE,
PREVIEW_IMG_SIZE,
pixels,
);
cache.insert(key, handle.clone());
handle
}
```
### 4. Update existing thumbnail cache to new size
- Keep `BRUSH_PREVIEW_CACHE` for style-only previews.
- Regenerate it with the new `THUMB_SIZE` (40 px). The existing sine-wave `generate_brush_preview` can stay, just adjust the drawing bounds to match.
- Ensure the function returns `width=THUMB_SIZE, height=THUMB_SIZE` pixels.
### 5. Re-layout the grid
Change the grid construction from 2 columns to 3 columns using `GRID_COLUMNS`:
```rust
let mut grid_rows = column![].spacing(GRID_SPACING);
let mut current_row = row![].spacing(GRID_SPACING);
for (idx, preset) in filtered_styles.iter().enumerate() {
// ... build 40 px cell with 36 px image + 8 px label ...
current_row = current_row.push(clickable);
if (idx + 1) % GRID_COLUMNS == 0 || idx == filtered_styles.len() - 1 {
grid_rows = grid_rows.push(current_row);
current_row = row![].spacing(GRID_SPACING);
}
}
```
Apply the same 3-column compact layout to:
- Built-in styles grid.
- Watercolor presets grid.
- Media presets grid.
For imported presets, keep the list-row layout but set the preview image to 36 px and container to 40 px.
### 6. Replace the bottom static preview with the live preview
Locate the existing code:
```rust
let preview_handle = get_brush_preview(current_style);
let live_preview = container(iced::widget::image(preview_handle).width(64).height(64))
...
```
Replace with:
```rust
let preview_handle = get_live_stamp_preview(
current_style,
current_size,
current_opacity,
current_hardness,
fg_color,
);
let live_preview = container(iced::widget::image(preview_handle).width(PREVIEW_IMG_SIZE as f32).height(PREVIEW_IMG_SIZE as f32))
.width(Length::Fill)
.height(56)
.center_x(Length::Fill)
.center_y(Length::Fill)
.style(move |_theme| styles::recessed_control(colors));
```
Make the preview area slightly shorter (56 px instead of 80 px) to reclaim vertical space.
### 7. Tighten slider/controls spacing
- Reduce the column padding from `4` to `3`.
- Keep sliders, but make the panel column spacing `2` or `3`.
---
## Affected Files
1. `hcie-iced-app/crates/hcie-iced-gui/src/panels/brushes.rs` — main panel layout and preview logic.
2. `hcie-iced-app/crates/hcie-iced-gui/src/dock/view.rs` — pass `app.fg_color` to `brushes::view`.
No engine crates are modified. No `Cargo.toml` changes are needed because `hcie_engine_api` is already a dependency.
---
## Validation
1. `cargo check -p hcie-iced-gui` must pass.
2. `cargo test -p hcie-iced-gui brushes` (or `cargo test -p hcie-iced-gui`) must pass; the existing tests in `brushes.rs` (`catalog_contains_every_engine_brush_style`, `category_filter_keeps_expected_groups`, `media_crates_expose_complete_unique_catalog`) must remain green.
3. Launch the Iced GUI and open the Brushes & Tips panel. Visually verify:
- 3-column grid of 40 px cells.
- 8 px labels still readable.
- Bottom preview area updates when size, opacity, hardness, or foreground color changes.
- Selection border still highlights the active brush.
4. If the Iced CLI screenshot mechanism works, capture the Brushes panel for before/after comparison.
---
## Risks
1. **Cache growth**: the parameter-keyed cache can grow quickly if size/opacity/hardness are continuous. Mitigation: quantize size to `u8`, hardness/opacity to 0..100, and fg color to full bytes; this bounds the space to ~256 * 101 * 101 * 256^4 possible keys but only populated entries consume memory.
2. **Performance of `render_brush_stamp_preview`**: small single-dab previews (36x36 or 40x40) should be fast; if not, consider throttling updates to panel redraws only.
3. **Iced layout overflow**: switching to 3 columns with 3 px spacing in a narrow pane may still wrap. If so, the pane minimum width in `dock/sizing.rs` may need a small bump (currently 160 px preferred 300 px). Test first; only bump if required.
4. **Tests assume style-only cache**: the existing `BRUSH_PREVIEW_CACHE` tests do not inspect cache contents, so resizing should not break them.
---
## Out of Scope
- EGUI (`hcie-egui-app`) changes — explicitly excluded by the user; it remains a reference only.
- Engine-side brush rendering changes — engine crates are locked.
- New brush engine presets or categories.
- Bitmap/imported brush stamp preview fidelity beyond what `render_brush_stamp_preview` already provides.
@@ -0,0 +1,282 @@
# Brush Checkerboard Fix + AGENTS.md Update Plan
## Context
- Project root: `/mnt/extra/00_PROJECTS/hcie-rust-v3.05`
- Active GUI: `hcie-iced-app/` (Iced + wgpu). `hcie-egui-app/` is legacy/abandoned.
- The reported artifact is a regular grid/checkerboard inside brush strokes on white canvas, visible only with certain brushes.
- `AGENTS.md` is outdated: it still says "HCIE-Rust v4", lists egui as the active GUI, and omits the iced workspace.
## Part 1: Brush Checkerboard Root Cause
The grid comes from deterministic, canvas-space pseudo-random sampling in `hcie-brush-engine/src/lib.rs`:
- `draw_grain_brush(..., woven: bool)` uses:
```rust
let hash = ((x.wrapping_mul(73_856_093) ^ y.wrapping_mul(19_349_663)) & 1023) as f32 / 1023.0;
if texture < threshold { continue; }
```
- `draw_crayon_brush` uses the same constants and a hard `continue` skip:
```rust
let noise = ((px * 73_856_093) ^ (py * 19_349_663)) & 1023;
if grain < threshold { continue; }
```
Because the hash depends only on absolute pixel `(x, y)` and the same pixels are re-sampled on every overlapping dab, the skipped pixels form a rigid canvas-locked checkerboard.
### Affected Brush Styles
| Style | Function | Mechanism |
|-------|----------|-----------|
| `Noise` | `draw_grain_brush(..., woven=false)` | hash threshold skip |
| `Texture` | `draw_grain_brush(..., woven=true)` | sin/cos woven threshold skip |
| `Pencil` | `draw_pencil_brush` → `draw_grain_brush` | hash threshold skip |
| `Charcoal` | `draw_charcoal_brush` → `draw_grain_brush` | hash threshold skip |
| `Sketch` | `draw_sketch_brush` → `draw_grain_brush` | hash threshold skip |
| `Crayon` | `draw_crayon_brush` | hash threshold skip |
Dry-media presets that map to these styles are also affected:
- Compressed Charcoal, Vine Charcoal, Charcoal Pencil
- Soft Pastel, Hard Pastel, Oil Pastel, Water-Soluble Pastel, PanPastel, Chalk Sanguine
- Graphite Pencils (HB/9B/Carpenter), Wax/Oil/Watercolor Pencils
Styles **not** affected: Round, HardRound, SoftRound, Square, Star, Spray, Pen, InkPen, Calligraphy, Oil, Airbrush, Watercolor, Marker, Glow, WetPaint, Leaf, Rock, Meadow, Clouds, Dirt, Tree, Bristle, Wood, Mixer, Blender, Bitmap.
## Part 2: Proposed Fix
### Decision
Apply both mechanisms together:
1. **Per-dab grain seed offset** in `draw_grain_brush` / `draw_crayon_brush` so consecutive dabs no longer hit the exact same canvas pixels.
2. **Convert hard threshold skip to alpha modulation** so "empty" pores become translucent rather than fully transparent, removing the rigid checkerboard.
### Implementation Details
#### 2.1 `draw_grain_brush` changes
Location: `hcie-brush-engine/src/lib.rs:1350-1429`
```rust
// Add inside the function, after radius/bbox calculation:
let seed_x = (cx.to_bits().wrapping_mul(73_856_093)
^ cy.to_bits().wrapping_mul(19_349_663)) as u32;
let seed_y = seed_x.wrapping_mul(668_265_263);
// Replace the hash computation with decorrelated coordinates:
let ox = x.wrapping_add(seed_x);
let oy = y.wrapping_add(seed_y);
let hash = ((ox.wrapping_mul(73_856_093) ^ oy.wrapping_mul(19_349_663)) & 1023) as f32 / 1023.0;
// For woven mode, shift the sin/cos arguments by the seed:
let texture = if woven {
0.55 + 0.45 * ((x as f32 * 0.42 + seed_x as f32 * 0.001).sin()
* (y as f32 * 0.31 + seed_y as f32 * 0.001).cos()).abs()
} else {
hash
};
// Replace `if texture < threshold { continue; }` with soft alpha modulation:
let grain_alpha = if texture < threshold {
(texture / threshold).clamp(0.0, 1.0)
} else {
0.55 + 0.45 * texture
};
// Use grain_alpha in the final alpha instead of the old `(0.55 + 0.45 * texture)` factor.
```
#### 2.2 `draw_crayon_brush` changes
Location: `hcie-brush-engine/src/lib.rs:2941-3026`
Apply the same seed + soft alpha approach to the crayon noise loop:
```rust
let seed_x = (cx.to_bits().wrapping_mul(73_856_093)
^ cy.to_bits().wrapping_mul(19_349_663)) as u32;
let seed_y = seed_x.wrapping_mul(668_265_263);
// inside pixel loop:
let ox = px.wrapping_add(seed_x);
let oy = py.wrapping_add(seed_y);
let noise = (ox.wrapping_mul(73_856_093) ^ oy.wrapping_mul(19_349_663)) & 1023;
let grain = noise as f32 / 1023.0;
let threshold = 0.18 * (1.0 - pressure) + 0.08;
let grain_alpha = if grain < threshold {
(grain / threshold).clamp(0.0, 1.0)
} else {
0.35 + 0.65 * grain
};
// use grain_alpha instead of `(0.35 + 0.65 * grain)`.
```
#### 2.3 Preset tuning (optional, verify visually)
If the new soft alpha makes dry-media strokes too dark or too dense, tune `hcie-dry-media-brushes/src/lib.rs`:
- Reduce `opacity` slightly for charcoal/pastel presets.
- Increase `spacing` a little for coarse charcoal presets.
Do **not** add jitter as the primary fix; jitter alone does not break the canvas-space hash pattern.
## Part 3: AGENTS.md Update
`AGENTS.md` currently describes the old egui-first architecture. Update it to match the actual project state.
### 3.1 Title & Mission
Change:
```markdown
# HCIE-Rust v4 — AI-Aware Architecture
```
to:
```markdown
# HCIE-Rust v3.05 — AI-Aware Architecture
```
Add a note:
```markdown
> Note: `v3.05` is the in-repo identifier for what was previously labelled "v4" in older documentation and paths. The egui workspace is no longer maintained; the active native GUI is the Iced workspace.
```
### 3.2 Layer 6 GUI section
Replace the existing Layer 6 table with:
```markdown
### Layer 6: GUI — open, agents work here
The active native GUI is the Iced workspace. The egui workspace exists for legacy reference but is not the current target.
| Crate / Project | Directory | Responsibility | Dependencies |
|-----------------|-----------|----------------|--------------|
| `hcie-iced-app` | `hcie-iced-app/` | Workspace root for the native Iced GUI. | `hcie-engine-api`, `hcie-iced-gui`, panels |
| `hcie-iced-gui` | `hcie-iced-app/crates/hcie-iced-gui/` | Main binary and application orchestration. | `hcie-engine-api`, panels |
| `iced-panel-adapter` | `hcie-iced-app/crates/iced-panel-adapter/` | Dynamic schema-to-widget UI binder. | `hcie-engine-api` |
| `iced-panel-ai-chat` | `hcie-iced-app/crates/iced-panel-ai-chat/` | AI chat panel. | `hcie-engine-api`, `hcie-ai` |
| `iced-panel-script` | `hcie-iced-app/crates/iced-panel-script/` | Scripting / automation panel. | `hcie-engine-api` |
| `hcie-dry-media-brushes` | `hcie-iced-app/crates/hcie-dry-media-brushes/` | Dry-media brush presets. | `hcie-engine-api` |
| `hcie-watercolor-brushes` | `hcie-iced-app/crates/hcie-watercolor-brushes/` | Watercolor brush presets + splat preview. | `hcie-engine-api` |
| `hcie-ink-brushes` | `hcie-iced-app/crates/hcie-ink-brushes/` | Ink brush presets. | `hcie-engine-api` |
| `hcie-paint-brushes` | `hcie-iced-app/crates/hcie-paint-brushes/` | Paint brush presets. | `hcie-engine-api` |
| `hcie-digital-brushes` | `hcie-iced-app/crates/hcie-digital-brushes/` | Digital/vector brush presets. | `hcie-engine-api` |
```
Keep the egui workspace mentioned in a short "Legacy / frozen" subsection so existing paths are not a surprise, but mark it clearly as not to be modified.
### 3.3 Build Order
Update Layer 6 line to:
```
Layer 6: hcie-iced-app / hcie-iced-gui
```
### 3.4 Performance Protection Notes
Replace egui-specific references with Iced equivalents:
- `hcie-egui-app/crates/hcie-gui-egui/src/app/mod.rs` → `hcie-iced-app/crates/hcie-iced-gui/src/app.rs`
- `hcie-egui-app/crates/hcie-gui-egui/src/canvas/mod.rs` → `hcie-iced-app/crates/hcie-iced-gui/src/canvas/mod.rs`
- Keep all wgpu/Shader/RefCell dirty bounds/Nearest-Neighbor protections as-is (they already describe the Iced path).
### 3.5 Screenshot & Visual Verification
Replace the egui screenshot section with the Iced CLI and F12 mechanisms documented in `hcie-iced-app/crates/hcie-iced-gui/src/cli.rs` and `screenshot.rs`:
```bash
# Full viewport
cargo run -p hcie-iced-gui -- --screenshot output.png
# Named panel
cargo run -p hcie-iced-gui -- --screenshot-panel "Brushes" output.png
```
Available panel names: inspect `src/screenshot.rs` / `src/dock/state.rs` for the exact name list.
### 3.6 Open Files List
Update the "Open Files" section to the iced paths:
```markdown
- `hcie-iced-app/crates/hcie-iced-gui/src/*.rs`
- `hcie-iced-app/crates/hcie-iced-gui/Cargo.toml`
- `hcie-iced-app/crates/iced-panel-adapter/src/*.rs`
- `hcie-iced-app/crates/iced-panel-ai-chat/src/*.rs`
- `hcie-iced-app/crates/iced-panel-script/src/*.rs`
- `hcie-iced-app/crates/hcie-dry-media-brushes/src/*.rs`
- `hcie-iced-app/crates/hcie-watercolor-brushes/src/*.rs`
- `hcie-iced-app/crates/hcie-ink-brushes/src/*.rs`
- `hcie-iced-app/crates/hcie-paint-brushes/src/*.rs`
- `hcie-iced-app/crates/hcie-digital-brushes/src/*.rs`
```
### 3.7 Important Notes
Update to:
- Never add an `egui` dependency to any engine crate.
- Never access `hcie-protocol` directly from GUI code.
- Never import a locked engine crate directly from GUI code; route everything through `hcie-engine-api`.
- The active GUI workspace is `hcie-iced-app/`. Treat `hcie-egui-app/` as read-only legacy reference.
## Part 4: Validation Steps
### 4.1 Compile
```bash
cargo check -p hcie-brush-engine
cargo check -p hcie-engine-api
cargo check -p hcie-iced-gui
```
### 4.2 Unit / regression tests
```bash
cargo test -p hcie-engine-api --test visual_regression
cargo test -p hcie-engine-api --test performance_stroke_4k -- --nocapture
cargo test -p hcie-dry-media-brushes
```
### 4.3 Visual verification (Iced)
1. Launch the Iced GUI.
2. Select a dry-media preset (e.g., Soft Pastel, Charcoal Pencil).
3. Draw several overlapping strokes on white canvas.
4. Confirm the checkerboard is gone and a soft paper-grain texture remains.
5. Compare with a round soft brush to ensure regular brushes are unchanged.
6. Capture before/after screenshots:
```bash
cargo run -p hcie-iced-gui -- --screenshot after_brushes.png
```
### 4.4 Lock crate after edits
Because `hcie-brush-engine` is a locked engine crate, unlock before editing and lock after:
```bash
./unlock.sh hcie-brush-engine
# ... apply source edits ...
cargo test -p hcie-engine-api --test visual_regression
./lock.sh hcie-brush-engine
```
## Risks & Rollback
- **Risk:** The alpha-modulation change may darken/lighten existing dry-media presets.
- *Mitigation:* Tune preset opacity/spacing after visual comparison.
- **Risk:** `visual_regression` golden hashes may change because brush pixel output changes.
- *Mitigation:* If the new output is visually correct, regenerate golden hashes with `HCIE_REGEN_GOLDENS=1 cargo test -p hcie-engine-api --test visual_regression -- --nocapture` and commit the updated hashes.
- **Risk:** `AGENTS.md` references to exact line numbers may drift.
- *Mitigation:* Replace line-number citations with file paths or function names where possible.
## Task Summary
1. ✅ Unlock `hcie-brush-engine` — file already writable (666), directory 555.
2. ✅ Edit `draw_grain_brush` — per-dab seed offset + soft alpha modulation applied.
3. ✅ Edit `draw_crayon_brush` — per-dab seed offset + soft alpha modulation applied.
4. ✅ Fix `generate_star_stamp` — changed from 5-pointed star to 4-pointed plus-cross.
5. ✅ Enhance `draw_star_brush` — added sparkle particle scatter around main dab.
6. ✅ Iced GUI: Renamed "Star" → "Star Sparkle", moved to Effects category.
7. ✅ Iced GUI: Updated `media_preset_category` to handle "Effects" category.
8. ✅ Egui GUI: Renamed "Stipple Dots" → "Star Sparkle" in styles grid.
9. ✅ Added "Star Sparkle" preset to `hcie-dry-media-brushes` crate (id: `star_sparkle`).
10. ✅ Updated preset count assertions (dry-media: 19→20, iced panel: 47→48).
11. ✅ `cargo check` passes for brush-engine, dry-media-brushes, iced-gui.
12. ✅ `cargo test -p hcie-dry-media-brushes` passes.
13. ⬜ Build and run `visual_regression` + `performance_stroke_4k` tests (needs full rebuild).
14. ⬜ Run Iced GUI, test affected presets, capture before/after screenshots.
15. ⬜ Update `AGENTS.md` to reflect v3.05 naming, the Iced workspace, and current open/locked boundaries.
16. ⬜ Lock `hcie-brush-engine` and `hcie-egui-app`.
+27 -21
View File
@@ -1,8 +1,8 @@
# HCIE-Rust v4 — AI-Aware Architecture
# HCIE-Rust v3.05 — AI-Aware Architecture
## Mission Statement
HCIE-Rust v4 is a pixel-grade image editor built around an atomic project split that prevents automated agents from corrupting the engine while still allowing them to iterate on the graphical user interface.
HCIE-Rust v3.05 is a pixel-grade image editor built around an atomic project split that prevents automated agents from corrupting the engine while still allowing them to iterate on the graphical user interface. The active native GUI is the **Iced** workspace (`hcie-iced-app/`). The `hcie-egui-app/` workspace is legacy/frozen — do not modify it for new features.
## Atomic Crate Split (23 crates / 6 layers)
@@ -56,13 +56,16 @@ One GUI workspace exists:
| Crate / Project | Directory | Responsibility | Dependencies |
|-----------------|-----------|----------------|--------------|
| `hcie-egui-app` | `hcie-egui-app/` | Workspace root for the native GUI. | `hcie-engine-api`, `eframe`, panels |
| `hcie-gui-egui` | `hcie-egui-app/crates/hcie-gui-egui/` | Main binary and application orchestration. | `hcie-engine-api`, panels |
| `egui-panel-adapter` | `hcie-egui-app/crates/egui-panel-adapter/` | Dynamic schema-to-widget UI binder. | `hcie-engine-api` |
| `egui-panel-filters` | `hcie-egui-app/crates/egui-panel-filters/` | Filter parameter panels. | `hcie-engine-api` |
| `egui-panel-ai-chat` | `hcie-egui-app/crates/egui-panel-ai-chat/` | AI chat panel. | `hcie-engine-api`, `hcie-ai` |
| `egui-panel-script` | `hcie-egui-app/crates/egui-panel-script/` | Scripting / automation panel. | `hcie-engine-api` |
| `egui-panel-ai-script` | `hcie-egui-app/crates/egui-panel-ai-script/` | AI-assisted script generation panel. | `hcie-engine-api`, `egui-panel-script` |
| `hcie-iced-app` | `hcie-iced-app/` | Workspace root for the native Iced GUI. | `hcie-engine-api`, `hcie-iced-gui`, panels |
| `hcie-iced-gui` | `hcie-iced-app/crates/hcie-iced-gui/` | Main binary and application orchestration. | `hcie-engine-api`, panels |
| `iced-panel-adapter` | `hcie-iced-app/crates/iced-panel-adapter/` | Dynamic schema-to-widget UI binder. | `hcie-engine-api` |
| `iced-panel-ai-chat` | `hcie-iced-app/crates/iced-panel-ai-chat/` | AI chat panel. | `hcie-engine-api`, `hcie-ai` |
| `iced-panel-script` | `hcie-iced-app/crates/iced-panel-script/` | Scripting / automation panel. | `hcie-engine-api` |
| `hcie-dry-media-brushes` | `hcie-iced-app/crates/hcie-dry-media-brushes/` | Dry-media brush presets (graphite, charcoal, pastel). | `hcie-engine-api` |
| `hcie-watercolor-brushes` | `hcie-iced-app/crates/hcie-watercolor-brushes/` | Watercolor brush presets. | `hcie-engine-api` |
| `hcie-ink-brushes` | `hcie-iced-app/crates/hcie-ink-brushes/` | Ink brush presets. | `hcie-engine-api` |
| `hcie-paint-brushes` | `hcie-iced-app/crates/hcie-paint-brushes/` | Paint brush presets. | `hcie-engine-api` |
| `hcie-digital-brushes` | `hcie-iced-app/crates/hcie-digital-brushes/` | Digital/vector brush presets. | `hcie-engine-api` |
## Critical Rules
@@ -82,7 +85,7 @@ Layer 2: hcie-blend, hcie-history, hcie-brush-engine, hcie-draw,
Layer 3: hcie-document
Layer 4: hcie-engine-api (rlib + staticlib)
Layer 5: hcie-ai, hcie-vision
Layer 6: hcie-egui-app / hcie-gui-egui
Layer 6: hcie-iced-app / hcie-iced-gui
```
## Performance Protection Notes (CRITICAL — Regression Prevention)
@@ -126,13 +129,13 @@ If a new feature conflicts with one of these mechanisms, extend the existing API
## GUI Workspace Architecture (CRITICAL — AI Search Scope)
Only one GUI workspace exists: `hcie-egui-app/`. The GUI crates are `hcie-gui-egui/` and `egui-panel-*/`.
Only one GUI workspace exists: `hcie-iced-app/`. The GUI crates are `hcie-iced-gui/` and `iced-panel-*/`. The `hcie-egui-app/` workspace is legacy and frozen.
### AI Search Rule
When searching for a crate, module, file, or symbol:
1. Scan the active GUI workspace first (`hcie-egui-app/`).
1. Scan the active GUI workspace first (`hcie-iced-app/`).
2. Then scan sibling engine crates (`../hcie-*/`).
3. Follow the `Cargo.toml` dependency chain; if a dependency lives in another workspace, scan that workspace too.
4. If a symbol name appears in two different modules (for example, `plugins/`), examine both.
@@ -169,15 +172,18 @@ Use `unlock.sh <crate>` to temporarily open a crate, make the required change, t
## Open Files (agents may write here)
### Active egui GUI
### Active Iced GUI
- `hcie-egui-app/crates/hcie-gui-egui/src/*.rs`
- `hcie-egui-app/crates/hcie-gui-egui/Cargo.toml`
- `hcie-egui-app/crates/egui-panel-adapter/src/*.rs`
- `hcie-egui-app/crates/egui-panel-filters/src/*.rs`
- `hcie-egui-app/crates/egui-panel-ai-chat/src/*.rs`
- `hcie-egui-app/crates/egui-panel-script/src/*.rs`
- `hcie-egui-app/crates/egui-panel-ai-script/src/*.rs`
- `hcie-iced-app/crates/hcie-iced-gui/src/*.rs`
- `hcie-iced-app/crates/hcie-iced-gui/Cargo.toml`
- `hcie-iced-app/crates/iced-panel-adapter/src/*.rs`
- `hcie-iced-app/crates/iced-panel-ai-chat/src/*.rs`
- `hcie-iced-app/crates/iced-panel-script/src/*.rs`
- `hcie-iced-app/crates/hcie-dry-media-brushes/src/*.rs`
- `hcie-iced-app/crates/hcie-watercolor-brushes/src/*.rs`
- `hcie-iced-app/crates/hcie-ink-brushes/src/*.rs`
- `hcie-iced-app/crates/hcie-paint-brushes/src/*.rs`
- `hcie-iced-app/crates/hcie-digital-brushes/src/*.rs`
## Important Notes
@@ -185,7 +191,7 @@ Use `unlock.sh <crate>` to temporarily open a crate, make the required change, t
- Never add an `egui` dependency to any engine crate.
- Never access `hcie-protocol` directly from GUI code.
- Never import a locked engine crate directly from GUI code; route everything through `hcie-engine-api`.
- The root `hcie-egui-app/Cargo.toml` currently lists `hcie-protocol`, `hcie-blend`, and `hcie-io` for legacy compatibility. Do not add new direct engine dependencies there.
- The active GUI workspace is `hcie-iced-app/`. Treat `hcie-egui-app/` as read-only legacy reference.
## Engine API — Public Surface
+198 -42
View File
@@ -111,7 +111,22 @@ pub fn generate_brush_stamp(tip: &BrushTip) -> Vec<u8> {
match tip.style {
BrushStyle::Round => generate_round_stamp(d, center, r, tip.hardness),
BrushStyle::Square => generate_square_stamp(d, center, r, tip.hardness),
BrushStyle::Star => generate_star_stamp(d, center, r, tip.hardness),
BrushStyle::Star => generate_star_stamp(
d,
center,
r,
tip.hardness,
if tip.roundness > 0.0 {
tip.roundness
} else {
0.22
},
if tip.density > 0.0 {
tip.density
} else {
0.08
},
),
BrushStyle::SoftRound => generate_round_stamp(d, center, r, 0.0),
BrushStyle::HardRound => generate_round_stamp(d, center, r, 1.0),
BrushStyle::Bitmap => {
@@ -200,27 +215,40 @@ fn generate_square_stamp(d: usize, center: f32, r: f32, hardness: f32) -> Vec<u8
.collect()
}
fn generate_star_stamp(d: usize, center: f32, r: f32, hardness: f32) -> Vec<u8> {
let points = 5u32;
let inner_r = r * 0.4;
fn generate_star_stamp(
d: usize,
center: f32,
r: f32,
hardness: f32,
arm_width_ratio: f32,
inner_r_ratio: f32,
) -> Vec<u8> {
let arm_count = 4u32;
let arm_width = arm_width_ratio.clamp(0.08, 0.35);
let inner_r = r * inner_r_ratio.clamp(0.04, 0.12);
let hardness = hardness.clamp(0.0, 1.0);
let point_sharpness = 1.2 + (0.35 - arm_width) / 0.27 * 2.8;
(0..d * d)
.map(|i| {
let x = (i % d) as f32 - center;
let y = (i / d) as f32 - center;
let angle = y.atan2(x);
let dist = (x * x + y * y).sqrt();
let point_angle = std::f32::consts::PI * 2.0 / points as f32;
let point_angle = std::f32::consts::PI * 2.0 / arm_count as f32;
let a = angle.rem_euclid(point_angle);
let edge = if a < point_angle / 2.0 {
inner_r + (r - inner_r) * (a / (point_angle / 2.0))
} else {
r - (r - inner_r) * ((a - point_angle / 2.0) / (point_angle / 2.0))
};
let arm_dist = a.min(point_angle - a);
let angular_distance = (arm_dist / (point_angle * 0.5)).clamp(0.0, 1.0);
let point_profile = (1.0 - angular_distance).powf(point_sharpness);
let edge = inner_r + (r - inner_r) * point_profile;
let soft_width = (r * (1.0 - hardness) * 0.35).max(0.75);
let hard_edge = (edge - soft_width).max(0.0);
if dist >= edge {
0
} else if dist <= hard_edge {
255
} else {
let alpha = 1.0 - (dist / edge).powf(1.0 - hardness.clamp(0.0, 0.99));
(alpha * 255.0).round() as u8
(((edge - dist) / soft_width).clamp(0.0, 1.0) * 255.0).round() as u8
}
})
.collect()
@@ -644,6 +672,10 @@ fn draw_brush_style_dab(
brush_hardness,
is_eraser,
mask,
angle,
rotation_random,
roundness,
density,
),
BrushStyle::Rock => draw_rock_brush(
pixels,
@@ -1374,6 +1406,11 @@ fn draw_grain_brush(
let x1 = (cx + radius).ceil().min(width.saturating_sub(1) as f32) as u32;
let y0 = (cy - radius).floor().max(0.0) as u32;
let y1 = (cy + radius).ceil().min(height.saturating_sub(1) as f32) as u32;
let seed_x = (cx.to_bits().wrapping_mul(73_856_093)
^ cy.to_bits().wrapping_mul(19_349_663)) as u32;
let seed_y = seed_x.wrapping_mul(668_265_263);
for y in y0..=y1 {
for x in x0..=x1 {
let dx = x as f32 - cx;
@@ -1382,16 +1419,22 @@ fn draw_grain_brush(
if distance > 1.0 {
continue;
}
let ox = x.wrapping_add(seed_x);
let oy = y.wrapping_add(seed_y);
let hash =
((x.wrapping_mul(73_856_093) ^ y.wrapping_mul(19_349_663)) & 1023) as f32 / 1023.0;
((ox.wrapping_mul(73_856_093) ^ oy.wrapping_mul(19_349_663)) & 1023) as f32 / 1023.0;
let texture = if woven {
0.55 + 0.45 * ((x as f32 * 0.42).sin() * (y as f32 * 0.31).cos()).abs()
0.55 + 0.45 * ((x as f32 * 0.42 + seed_x as f32 * 0.001).sin()
* (y as f32 * 0.31 + seed_y as f32 * 0.001).cos())
.abs()
} else {
hash
};
if texture < threshold {
continue;
}
let grain_alpha = if texture < threshold {
(texture / threshold).clamp(0.0, 1.0)
} else {
0.55 + 0.45 * texture
};
let falloff = if distance <= hardness {
1.0
} else {
@@ -1407,7 +1450,7 @@ fn draw_grain_brush(
* pressure
* falloff
* mask_alpha
* (0.55 + 0.45 * texture)
* grain_alpha
* (color[3] as f32 / 255.0);
let offset = index * 4;
if is_eraser {
@@ -1604,29 +1647,136 @@ fn draw_star_brush(
hardness: f32,
is_eraser: bool,
mask: Option<&[u8]>,
angle: f32,
rotation_random: f32,
roundness: f32,
density: f32,
) {
let effective_size = size * pressure;
let seed = cx.to_bits().wrapping_mul(73_856_093)
^ cy.to_bits().wrapping_mul(19_349_663);
let size_variance = roundness;
let size_scale = if size_variance > 0.0 {
let r = ((seed & 0xFFFF) as f32 / 65536.0 - 0.5) * 2.0 * size_variance;
(1.0 + r).clamp(0.3, 2.0)
} else {
1.0
};
let effective_size = size * pressure * size_scale;
let angle_variance = rotation_random;
let dab_angle = if angle_variance > 0.0 {
let r = ((seed >> 16) as f32 / 65536.0 - 0.5) * 2.0 * angle_variance;
angle + r * std::f32::consts::PI
} else {
angle
};
let arm_width_ratio = if roundness > 0.0 { roundness } else { 0.22 };
let inner_r_ratio = if density > 0.0 { density } else { 0.08 };
let tip = BrushTip {
style: BrushStyle::Star,
size: effective_size * 0.5,
hardness,
roundness: arm_width_ratio,
density: inner_r_ratio,
..BrushTip::default()
};
let stamp = generate_brush_stamp(&tip);
draw_dab_with_stamp(
pixels,
width,
height,
cx,
cy,
effective_size,
hardness,
color,
opacity * pressure,
is_eraser,
mask,
Some(&stamp),
);
let cos_a = dab_angle.cos();
let sin_a = dab_angle.sin();
let stamp_rotated = if dab_angle.abs() > f32::EPSILON {
let stamp_d = (effective_size * 0.5 * 2.0).ceil() as usize;
let stamp_center = stamp_d as f32 * 0.5;
let d = stamp_d;
let center = d as f32 * 0.5;
let mut rotated = vec![0u8; d * d];
for y in 0..d {
for x in 0..d {
let px = x as f32 - center;
let py = y as f32 - center;
let rx = px * cos_a + py * sin_a;
let ry = -px * sin_a + py * cos_a;
let sx = rx + stamp_center;
let sy = ry + stamp_center;
let ix = sx.floor() as i32;
let iy = sy.floor() as i32;
if ix >= 0 && iy >= 0 && ix < stamp_d as i32 - 1 && iy < stamp_d as i32 - 1 {
let fx = sx - ix as f32;
let fy = sy - iy as f32;
let d00 = stamp[iy as usize * stamp_d + ix as usize] as f32;
let d10 = stamp[iy as usize * stamp_d + ix as usize + 1] as f32;
let d01 = stamp[(iy as usize + 1) * stamp_d + ix as usize] as f32;
let d11 = stamp[(iy as usize + 1) * stamp_d + ix as usize + 1] as f32;
let v = d00 * (1.0 - fx) * (1.0 - fy)
+ d10 * fx * (1.0 - fy)
+ d01 * (1.0 - fx) * fy
+ d11 * fx * fy;
rotated[y * d + x] = v.round() as u8;
}
}
}
rotated
} else {
stamp
};
let sparkle_count = if density > 0.0 {
(effective_size * 0.08 * density).clamp(2.0, 6.0) as u32
} else {
((effective_size * 0.05) as u32).clamp(2, 4)
};
let base_star_size = effective_size * 0.24;
let footprint_radius = effective_size * 0.5;
let phase = (seed & 0xFFFF) as f32 / 65536.0 * std::f32::consts::TAU;
const GOLDEN_ANGLE: f32 = 2.399_963_1;
for i in 0..sparkle_count {
let hash_i = seed.wrapping_add(i.wrapping_mul(668_265_263));
let spark_size_var = if size_variance > 0.0 {
let rv = ((hash_i.wrapping_add(31337) & 0xFFFF) as f32 / 65536.0 - 0.5)
* 2.0
* size_variance;
(1.0 + rv).clamp(0.3, 2.0)
} else {
1.0
};
let star_size = base_star_size * spark_size_var;
let max_center_radius = (footprint_radius - star_size * 0.5).max(0.0);
let radial_fraction = ((i as f32 + 0.5) / sparkle_count as f32).sqrt();
let spark_angle = phase + i as f32 * GOLDEN_ANGLE;
let dist = radial_fraction * max_center_radius;
let sx = cx + spark_angle.cos() * dist;
let sy = cy + spark_angle.sin() * dist;
let spark_color = if color[3] > 0 {
let hue_shift = ((hash_i.wrapping_add(7919) & 0xFF) as f32 / 255.0 - 0.5) * 30.0;
let [r, g, b, a] = color;
let (h, s, l) = rgb_to_hsl(r, g, b);
let h = (h + hue_shift).rem_euclid(360.0);
let (rr, gg, bb) = hsl_to_rgb(h, s, l);
[rr, gg, bb, a]
} else {
color
};
draw_dab_with_stamp(
pixels,
width,
height,
sx,
sy,
star_size,
hardness,
spark_color,
opacity * pressure * 0.9,
is_eraser,
mask,
Some(&stamp_rotated),
);
}
}
/// Apply oil paint brush - coherent, directional bristle tracks with pigment pickup.
@@ -2964,6 +3114,10 @@ pub fn draw_crayon_brush(
let [fr, fg, fb, _] = color;
let seed_x = (cx.to_bits().wrapping_mul(73_856_093)
^ cy.to_bits().wrapping_mul(19_349_663)) as u32;
let seed_y = seed_x.wrapping_mul(668_265_263);
for py in y_min..=y_max {
for px in x_min..=x_max {
let dx = px as f32 - cx;
@@ -2990,20 +3144,22 @@ pub fn draw_crayon_brush(
(1.0 - (d_sq - hard_sq) * soft_range_inv).clamp(0.0, 1.0)
};
// Stable canvas-space paper tooth keeps pores aligned across consecutive dabs.
let noise = ((px as u32).wrapping_mul(73_856_093)
^ (py as u32).wrapping_mul(19_349_663))
& 1023;
let grain = noise as f32 / 1023.0;
if grain < 0.18 * (1.0 - pressure) + 0.08 {
continue;
}
let ox = (px as u32).wrapping_add(seed_x);
let oy = (py as u32).wrapping_add(seed_y);
let noise = ox.wrapping_mul(73_856_093) ^ oy.wrapping_mul(19_349_663);
let grain = (noise & 1023) as f32 / 1023.0;
let threshold = 0.18 * (1.0 - pressure) + 0.08;
let grain_alpha = if grain < threshold {
(grain / threshold).clamp(0.0, 1.0)
} else {
0.35 + 0.65 * grain
};
let brush_alpha = (alpha_factor
* opacity
* pressure
* (color[3] as f32 / 255.0)
* (0.35 + 0.65 * grain)
* grain_alpha
* (mask_val as f32 / 255.0)
* 255.0)
.round() as u8;
@@ -1718,7 +1718,7 @@ pub fn show_brushes_ui(app: &mut HcieApp, ui: &mut egui::Ui) {
(hcie_engine_api::tools::BrushStyle::Marker, "Marker"),
(hcie_engine_api::tools::BrushStyle::Sketch, "Sketch"),
(hcie_engine_api::tools::BrushStyle::Hatch, "Hatch"),
(hcie_engine_api::tools::BrushStyle::Star, "Stipple Dots"),
(hcie_engine_api::tools::BrushStyle::Star, "Star Sparkle"),
(hcie_engine_api::tools::BrushStyle::Glow, "Glow"),
(hcie_engine_api::tools::BrushStyle::Airbrush, "Airbrush"),
(hcie_engine_api::tools::BrushStyle::Pencil, "Pencil"),
+46 -21
View File
@@ -117,17 +117,25 @@ impl Engine {
if mask.len() != full_size {
let mut full_mask = vec![layer.mask_default_color; full_size];
if let Some(mb) = layer.mask_bounds {
let (m_top, m_left, m_bottom, m_right) =
(mb[0].max(0) as u32, mb[1].max(0) as u32, mb[2].max(0) as u32, mb[3].max(0) as u32);
let (m_top, m_left, m_bottom, m_right) = (
mb[0].max(0) as u32,
mb[1].max(0) as u32,
mb[2].max(0) as u32,
mb[3].max(0) as u32,
);
let mw = (m_right - m_left) as usize;
let mh = (m_bottom - m_top) as usize;
if mw > 0 && mh > 0 && mask.len() == mw * mh {
for y in 0..mh {
let gy = m_top as usize + y;
if gy >= ch as usize { break; }
if gy >= ch as usize {
break;
}
for x in 0..mw {
let gx = m_left as usize + x;
if gx >= cw as usize { break; }
if gx >= cw as usize {
break;
}
full_mask[gy * cw as usize + gx] = mask[y * mw + x];
}
}
@@ -181,7 +189,9 @@ impl Engine {
let cw = self.document.canvas_width as usize;
let ch = self.document.canvas_height as usize;
let mask_len = cw * ch;
if mask_len == 0 { return; }
if mask_len == 0 {
return;
}
if let Some(layer) = self.document.get_layer_by_id_mut(layer_id) {
if layer.mask_pixels.is_none() {
@@ -270,10 +280,6 @@ impl Engine {
let w = self.document.canvas_width as f32;
let h = self.document.canvas_height as f32;
let inside = x >= 0.0 && y >= 0.0 && x < w && y < h;
if !inside {
self.last_stroke_pos = None;
return;
}
let tip = self.brush_tip_with_time_dynamics(x, y);
let color = self.apply_cyclic_color(self.current_color);
@@ -287,14 +293,24 @@ impl Engine {
let is_eraser = self.is_eraser;
let dirty_r = Self::brush_dirty_radius(&tip);
self.document.expand_dirty(lx as u32, ly as u32, dirty_r);
self.document.expand_dirty(x as u32, y as u32, dirty_r);
self.expand_stroke_bounds(lx as u32, ly as u32, dirty_r);
self.expand_stroke_bounds(x as u32, y as u32, dirty_r);
if lx >= 0.0 && ly >= 0.0 && lx < w && ly < h {
self.document.expand_dirty(lx as u32, ly as u32, dirty_r);
self.expand_stroke_bounds(lx as u32, ly as u32, dirty_r);
}
if inside {
self.document.expand_dirty(x as u32, y as u32, dirty_r);
self.expand_stroke_bounds(x as u32, y as u32, dirty_r);
}
self.draw_target_pixels_or_mask(
layer_id,
|pixels, lw, lh, mask_ref, active_stroke_mask, stroke_before_buf, sketch_history| {
|pixels,
lw,
lh,
mask_ref,
active_stroke_mask,
stroke_before_buf,
sketch_history| {
let sketch_hist = if tip.style == BrushStyle::Sketch {
sketch_history
} else {
@@ -348,19 +364,28 @@ impl Engine {
let dirty_r = tip.size.max(2.0);
if let Some((lx, ly, _)) = self.last_stroke_pos {
self.document.expand_dirty(lx as u32, ly as u32, dirty_r);
if lx >= 0.0 && ly >= 0.0 && lx < w && ly < h {
self.document.expand_dirty(lx as u32, ly as u32, dirty_r);
self.expand_stroke_bounds(lx as u32, ly as u32, dirty_r);
}
}
self.document.expand_dirty(x as u32, y as u32, dirty_r);
if let Some((lx, ly, _)) = self.last_stroke_pos {
self.expand_stroke_bounds(lx as u32, ly as u32, dirty_r);
if inside {
self.document.expand_dirty(x as u32, y as u32, dirty_r);
self.expand_stroke_bounds(x as u32, y as u32, dirty_r);
}
self.expand_stroke_bounds(x as u32, y as u32, dirty_r);
if self.editing_mask {
self.draw_target_pixels_or_mask(
layer_id,
|pixels, lw, lh, mask_ref, active_stroke_mask, stroke_before_buf, _sketch_history| {
let mut temp_layer = hcie_protocol::Layer::from_rgba("temp", lw, lh, pixels.to_vec());
|pixels,
lw,
lh,
mask_ref,
active_stroke_mask,
stroke_before_buf,
_sketch_history| {
let mut temp_layer =
hcie_protocol::Layer::from_rgba("temp", lw, lh, pixels.to_vec());
draw_brush_stroke(
&mut temp_layer,
&[(x, y, pressure)],
@@ -233,6 +233,14 @@ pub fn dry_media_presets() -> Vec<BrushPreset> {
false,
true,
),
preset(
"star_sparkle",
"Star Sparkle",
"Effects",
tip(BrushStyle::Star, 14.0, 0.95, 1.0, 0.35),
true,
false,
),
]
}
@@ -245,14 +253,14 @@ mod tests {
#[test]
fn dry_media_catalog_is_complete_and_unique() {
let presets = dry_media_presets();
assert_eq!(presets.len(), 19);
assert_eq!(presets.len(), 20);
assert_eq!(
presets
.iter()
.map(|preset| &preset.id)
.collect::<HashSet<_>>()
.len(),
19
20
);
assert!(presets
.iter()
+96 -30
View File
@@ -587,6 +587,16 @@ pub struct ToolState {
pub brush_color_variant: bool,
/// Magnitude of the per-dab color variation (0.0..1.0).
pub brush_variant_amount: f32,
/// Star brush base rotation angle in radians.
pub brush_angle: f32,
/// Star brush per-dab size variance (0.0..1.0).
pub brush_size_variance: f32,
/// Star brush per-dab angle variance (0.0..1.0).
pub brush_angle_variance: f32,
/// True when the brush color should cycle through the hue over stroke distance.
pub brush_cyclic_color: bool,
/// Speed of the hue cycle along the stroke (0.01..5.0).
pub brush_cyclic_speed: f32,
/// Timestamp of the last update() call for frame timing.
pub last_update_instant: std::time::Instant,
/// Imported brush presets from ABR/KPP files.
@@ -621,6 +631,11 @@ impl Default for ToolState {
brush_spacing: 1.0,
brush_color_variant: false,
brush_variant_amount: 0.0,
brush_angle: 0.0,
brush_size_variance: 0.0,
brush_angle_variance: 0.0,
brush_cyclic_color: false,
brush_cyclic_speed: 0.5,
last_update_instant: std::time::Instant::now(),
imported_brushes: Vec::new(),
active_brush_preset: None,
@@ -778,6 +793,11 @@ pub enum Message {
BrushSpacingChanged(f32),
BrushColorVariantToggled(bool),
BrushVariantAmountChanged(f32),
BrushAngleChanged(f32),
BrushSizeVarianceChanged(f32),
BrushAngleVarianceChanged(f32),
BrushCyclicColorToggled(bool),
BrushCyclicSpeedChanged(f32),
BrushImportAbr,
BrushImportAbrFile(Result<Vec<hcie_engine_api::BrushPreset>, String>),
ResetToolDefaults,
@@ -1315,10 +1335,14 @@ fn build_brush_tip(state: &ToolState) -> BrushTip {
spacing: state.brush_spacing,
color_variant: state.brush_color_variant,
variant_amount: state.brush_variant_amount,
angle: state.brush_angle,
roundness: state.brush_size_variance,
rotation_random: state.brush_angle_variance,
..BrushTip::default()
}
}
/// Converts an imported/default brush-engine preset tip into the protocol tip used by `Engine`.
///
/// **Arguments:** `source` is the preset-owned brush-engine tip. **Returns:** A protocol tip with
@@ -2564,7 +2588,7 @@ impl HcieIcedApp {
/// Apply brush parameters from tool state to the engine.
///
/// Called before starting a stroke to ensure the engine uses
/// the current brush size, opacity, hardness, and style.
/// the current brush size, opacity, hardness, style, and cyclic color.
fn apply_brush_params(&mut self) {
let mut tip = self
.tool_state
@@ -2577,6 +2601,15 @@ impl HcieIcedApp {
tip.opacity = self.tool_state.brush_opacity;
tip.hardness = self.tool_state.brush_hardness;
tip.spacing = self.tool_state.brush_spacing;
// Cyclic color is handled by engine state, not the tip, but preview rendering
// also reads the tip's time dynamics. Synchronize both here.
tip.time_enabled = self.tool_state.brush_cyclic_color;
tip.time_size_start = 1.0;
tip.time_size_end = 1.0;
tip.time_opacity_start = 1.0;
tip.time_opacity_end = 1.0;
tip.time_angle_start = 0.0;
tip.time_angle_end = 0.0;
match self.tool_state.active_tool {
Tool::Pen => {
tip.style = BrushStyle::Round;
@@ -2592,7 +2625,10 @@ impl HcieIcedApp {
}
_ => {}
}
self.documents[self.active_doc].engine.set_brush_tip(tip);
let engine = &mut self.documents[self.active_doc].engine;
engine.set_brush_tip(tip);
engine.set_cyclic_color(self.tool_state.brush_cyclic_color);
engine.set_cyclic_speed(self.tool_state.brush_cyclic_speed);
}
/// Push the current SVG editor model into the active vector shape so the
@@ -2901,11 +2937,14 @@ impl HcieIcedApp {
let paint_tool =
matches!(tool, Tool::Pen | Tool::Brush | Tool::Eraser | Tool::Spray);
if paint_tool && (self.modifiers.control() || self.modifiers.logo()) {
let cx = canvas_x as u32;
let cy = canvas_y as u32;
let width = self.documents[self.active_doc].engine.canvas_width();
if cx < width && cy < self.documents[self.active_doc].engine.canvas_height() {
let index = ((cy * width + cx) * 4) as usize;
let height = self.documents[self.active_doc].engine.canvas_height();
if canvas_x >= 0.0
&& canvas_y >= 0.0
&& (canvas_x as u32) < width
&& (canvas_y as u32) < height
{
let index = ((canvas_y as u32 * width + canvas_x as u32) * 4) as usize;
if index + 3 < self.documents[self.active_doc].composite_raw.len() {
let pixels = &self.documents[self.active_doc].composite_raw;
let color = [
@@ -3247,13 +3286,11 @@ impl HcieIcedApp {
let is_ctrl = self.modifiers.control() || self.modifiers.logo();
if is_ctrl {
// Pick color
let cx = x as u32;
let cy = y as u32;
let w = self.documents[self.active_doc].engine.canvas_width();
let h = self.documents[self.active_doc].engine.canvas_height();
if cx < w && cy < h {
if x >= 0.0 && y >= 0.0 && (x as u32) < w && (y as u32) < h {
let pixels = &self.documents[self.active_doc].composite_raw;
let idx = ((cy * w + cx) * 4) as usize;
let idx = ((y as u32 * w + x as u32) * 4) as usize;
if idx + 3 < pixels.len() {
let color = [
pixels[idx],
@@ -3719,7 +3756,9 @@ impl HcieIcedApp {
}
Message::LayerSetEditMask(editing) => {
self.documents[self.active_doc].engine.set_editing_mask(editing);
self.documents[self.active_doc]
.engine
.set_editing_mask(editing);
self.documents[self.active_doc].cached_layers =
self.documents[self.active_doc].engine.layer_infos();
}
@@ -4952,6 +4991,37 @@ impl HcieIcedApp {
self.settings.update_from_tool_state(&self.tool_state);
let _ = self.settings.save();
}
Message::BrushAngleChanged(angle) => {
self.tool_state.brush_angle = angle;
self.settings.update_from_tool_state(&self.tool_state);
let _ = self.settings.save();
}
Message::BrushSizeVarianceChanged(variance) => {
self.tool_state.brush_size_variance = variance;
self.settings.update_from_tool_state(&self.tool_state);
let _ = self.settings.save();
}
Message::BrushAngleVarianceChanged(variance) => {
self.tool_state.brush_angle_variance = variance;
self.settings.update_from_tool_state(&self.tool_state);
let _ = self.settings.save();
}
Message::BrushCyclicColorToggled(enabled) => {
self.tool_state.brush_cyclic_color = enabled;
self.documents[self.active_doc]
.engine
.set_cyclic_color(enabled);
self.settings.update_from_tool_state(&self.tool_state);
let _ = self.settings.save();
}
Message::BrushCyclicSpeedChanged(speed) => {
self.tool_state.brush_cyclic_speed = speed;
self.documents[self.active_doc]
.engine
.set_cyclic_speed(speed);
self.settings.update_from_tool_state(&self.tool_state);
let _ = self.settings.save();
}
Message::SelectionToleranceChanged(tol) => {
self.settings.tool_settings.magic_wand_tolerance = tol as f32;
self.settings.tool_settings.flood_fill_tolerance = tol as f32;
@@ -6711,10 +6781,8 @@ impl HcieIcedApp {
self.settings.tool_settings.vector_angle = angle.to_degrees();
// Track snap state for visual overlay feedback
let is_rotate = matches!(
session.handle,
hcie_engine_api::VectorEditHandle::Rotate
);
let is_rotate =
matches!(session.handle, hcie_engine_api::VectorEditHandle::Rotate);
let is_resize = matches!(
session.handle,
hcie_engine_api::VectorEditHandle::TopLeft
@@ -7784,7 +7852,8 @@ impl HcieIcedApp {
}
Message::PasteImage => {
// Check internal clipboard first
if let Some(transform) = self.documents[self.active_doc].internal_clipboard.clone() {
if let Some(transform) = self.documents[self.active_doc].internal_clipboard.clone()
{
// Enter transform mode with the clipboard content
let mut placed = transform;
placed.pos.x += 10.0;
@@ -8481,12 +8550,10 @@ impl HcieIcedApp {
return self.update(Message::OpenFileRfd);
}
Message::FileOpened(Ok(path)) => {
match self.open_path_in_new_tab(path, true) {
Ok(_) => return Task::perform(async {}, |_| Message::CompositeRefresh),
Err(error) => log::error!("Failed to open file: {error}"),
}
}
Message::FileOpened(Ok(path)) => match self.open_path_in_new_tab(path, true) {
Ok(_) => return Task::perform(async {}, |_| Message::CompositeRefresh),
Err(error) => log::error!("Failed to open file: {error}"),
},
Message::FileOpened(Err(e)) => {
log::error!("Failed to open file: {}", e);
@@ -9153,9 +9220,7 @@ impl HcieIcedApp {
| crate::theme::ThemePreset::ProDark
| crate::theme::ThemePreset::Amoled => crate::theme::ThemePreset::ProLight,
crate::theme::ThemePreset::PhotoshopLight
| crate::theme::ThemePreset::ProLight => {
crate::theme::ThemePreset::Photopea
}
| crate::theme::ThemePreset::ProLight => crate::theme::ThemePreset::Photopea,
};
self.theme_state.set_preset(new_preset);
self.settings.theme_preset = new_preset;
@@ -10308,10 +10373,8 @@ mod cycle_one_ux_tests {
.duration_since(std::time::UNIX_EPOCH)
.unwrap()
.as_nanos();
let path = std::env::temp_dir().join(format!(
"hcie-open-tab-{}-{unique}.png",
std::process::id()
));
let path =
std::env::temp_dir().join(format!("hcie-open-tab-{}-{unique}.png", std::process::id()));
image::save_buffer(
&path,
&[255, 0, 0, 255, 0, 255, 0, 255],
@@ -10328,7 +10391,10 @@ mod cycle_one_ux_tests {
assert_eq!(app.active_doc, 1);
assert_eq!(app.documents[0].name, original_name);
assert!(app.documents[0].source_path.is_none());
assert_eq!(app.documents[1].source_path.as_deref(), Some(path.as_path()));
assert_eq!(
app.documents[1].source_path.as_deref(),
Some(path.as_path())
);
assert_eq!(app.documents[1].engine.canvas_width(), 2);
assert_eq!(app.documents[1].engine.canvas_height(), 1);
@@ -985,8 +985,7 @@ fn should_publish_cursor_status(
current: (u32, u32),
elapsed: Option<std::time::Duration>,
) -> bool {
previous != Some(current)
&& elapsed.map_or(true, |duration| duration >= CURSOR_STATUS_INTERVAL)
previous != Some(current) && elapsed.map_or(true, |duration| duration >= CURSOR_STATUS_INTERVAL)
}
/// Canvas shader program — implements `iced::widget::shader::Program`.
@@ -1024,8 +1023,9 @@ pub struct CanvasShaderProgram {
/// Convert a viewport-local point to canvas-space coordinates.
///
/// `local_pos` is relative to the shader widget's top-left corner.
/// `viewport_size` is the widget's size. Returns `(Some(x), Some(y))`
/// when inside the canvas image bounds, otherwise `(None, None)`.
/// `viewport_size` is the widget's size. Returns the full signed canvas
/// coordinates even when the cursor is outside the visible canvas image,
/// so brush strokes can continue mathematically beyond the canvas edges.
fn screen_to_canvas_local(
local_pos: Point,
viewport_w: f32,
@@ -1053,17 +1053,7 @@ fn screen_to_canvas_local(
let canvas_x = (local_pos.x - origin_x) / zoom;
let canvas_y = (local_pos.y - origin_y) / zoom;
let cx = if canvas_x >= 0.0 && canvas_x < engine_w {
Some(canvas_x)
} else {
None
};
let cy = if canvas_y >= 0.0 && canvas_y < engine_h {
Some(canvas_y)
} else {
None
};
(cx, cy)
(Some(canvas_x), Some(canvas_y))
}
impl shader::Program<Message> for CanvasShaderProgram {
@@ -1106,8 +1096,8 @@ impl shader::Program<Message> for CanvasShaderProgram {
// Left mouse drag (drawing)
if state.left_pressed {
let cx = canvas_x.unwrap_or(0.0).clamp(0.0, self.engine_w as f32);
let cy = canvas_y.unwrap_or(0.0).clamp(0.0, self.engine_h as f32);
let cx = canvas_x.unwrap_or(0.0);
let cy = canvas_y.unwrap_or(0.0);
return (
iced::event::Status::Captured,
Some(Message::CanvasPointerMoved {
@@ -110,23 +110,44 @@ impl Program<Message> for CanvasViewportProgram {
let mut frame = Frame::new(bounds.size());
// Draw checkerboard background (tiled to cover display area)
let checker_pattern = canvas::Pattern::new(&cfg.checker_handle).mode(canvas::PatternMode::Repeat);
let checker_path = Path::rectangle(Point::new(origin_x, origin_y), Size::new(display_w, display_h));
let checker_pattern =
canvas::Pattern::new(&cfg.checker_handle).mode(canvas::PatternMode::Repeat);
let checker_path = Path::rectangle(
Point::new(origin_x, origin_y),
Size::new(display_w, display_h),
);
frame.fill(&checker_path, checker_pattern);
// Draw composite texture
let composite_image = canvas::Image::new(&cfg.composite_handle)
.destination_rectangle(Rectangle::new(Point::new(origin_x, origin_y), Size::new(display_w, display_h)));
let composite_image =
canvas::Image::new(&cfg.composite_handle).destination_rectangle(Rectangle::new(
Point::new(origin_x, origin_y),
Size::new(display_w, display_h),
));
frame.draw_image(composite_image);
// Draw canvas border
let border_path = Path::rectangle(Point::new(origin_x, origin_y), Size::new(display_w, display_h));
frame.stroke(&border_path, Stroke::default().with_color(Color::from_rgb(0.35, 0.35, 0.35)).with_width(1.0));
let border_path = Path::rectangle(
Point::new(origin_x, origin_y),
Size::new(display_w, display_h),
);
frame.stroke(
&border_path,
Stroke::default()
.with_color(Color::from_rgb(0.35, 0.35, 0.35))
.with_width(1.0),
);
vec![frame.into_geometry()]
}
fn update(&self, state: &mut (), event: iced::Event, bounds: Rectangle, cursor: Cursor) -> (iced::widget::canvas::Status, Option<Message>) {
fn update(
&self,
state: &mut (),
event: iced::Event,
bounds: Rectangle,
cursor: Cursor,
) -> (iced::widget::canvas::Status, Option<Message>) {
let mut program_state = self.state.lock().unwrap();
match event {
@@ -140,17 +161,22 @@ impl Program<Message> for CanvasViewportProgram {
iced::mouse::Event::ButtonPressed(iced::mouse::Button::Left) => {
if let Some(pos) = program_state.last_cursor {
if bounds.contains(pos) {
let (cx, cy) = viewport_to_canvas(pos, bounds, &program_state.config);
let (cx, cy) =
viewport_to_canvas(pos, bounds, &program_state.config);
if let Some((cx, cy)) = (cx, cy) {
return (iced::widget::canvas::Status::Captured, Some(Message::CanvasPointerPressed { x: cx, y: cy }));
return (
iced::widget::canvas::Status::Captured,
Some(Message::CanvasPointerPressed { x: cx, y: cy }),
);
}
}
}
(iced::widget::canvas::Status::Captured, None)
}
iced::mouse::Event::ButtonReleased(iced::mouse::Button::Left) => {
(iced::widget::canvas::Status::Captured, Some(Message::CanvasPointerReleased))
}
iced::mouse::Event::ButtonReleased(iced::mouse::Button::Left) => (
iced::widget::canvas::Status::Captured,
Some(Message::CanvasPointerReleased),
),
iced::mouse::Event::Scrolled { delta } => {
if program_state.is_hovered {
let scroll_delta = match delta {
@@ -164,8 +190,13 @@ impl Program<Message> for CanvasViewportProgram {
let new_zoom = (old_zoom * factor).clamp(0.1, 10.0);
if let Some(cursor_pos) = program_state.last_cursor {
let (canvas_x, canvas_y) = viewport_to_canvas(cursor_pos, bounds, &program_state.config).unwrap_or((0.0, 0.0));
let (canvas_x, canvas_y) = viewport_to_canvas(
cursor_pos,
bounds,
&program_state.config,
)
.unwrap_or((0.0, 0.0));
// Calculate new pan_offset to keep cursor over same canvas point
let display_w = program_state.config.engine_w as f32 * new_zoom;
let display_h = program_state.config.engine_h as f32 * new_zoom;
@@ -173,12 +204,19 @@ impl Program<Message> for CanvasViewportProgram {
let new_origin_y = cursor_pos.y - canvas_y * new_zoom;
let new_default_origin_x = (bounds.width - display_w) / 2.0;
let new_default_origin_y = (bounds.height - display_h) / 2.0;
program_state.config.pan_offset.x = new_origin_x - new_default_origin_x;
program_state.config.pan_offset.y = new_origin_y - new_default_origin_y;
program_state.config.pan_offset.x =
new_origin_x - new_default_origin_x;
program_state.config.pan_offset.y =
new_origin_y - new_default_origin_y;
}
program_state.config.zoom = new_zoom;
return (iced::widget::canvas::Status::Captured, Some(Message::CanvasZoom { delta: scroll_delta }));
return (
iced::widget::canvas::Status::Captured,
Some(Message::CanvasZoom {
delta: scroll_delta,
}),
);
}
}
(iced::widget::canvas::Status::Ignored, None)
@@ -190,7 +228,12 @@ impl Program<Message> for CanvasViewportProgram {
}
}
fn mouse_interaction(&self, _state: &(), bounds: Rectangle, cursor: Cursor) -> iced::mouse::Interaction {
fn mouse_interaction(
&self,
_state: &(),
bounds: Rectangle,
cursor: Cursor,
) -> iced::mouse::Interaction {
if cursor.is_over(bounds) {
iced::mouse::Interaction::Crosshair
} else {
@@ -200,7 +243,14 @@ impl Program<Message> for CanvasViewportProgram {
}
/// Convert viewport-space coordinates to canvas-space coordinates.
fn viewport_to_canvas(viewport_pos: Point, bounds: Rectangle, config: &CanvasViewportConfig) -> Option<(f32, f32)> {
///
/// Returns signed canvas coordinates even when the cursor is outside the canvas
/// image so brush strokes can start or continue beyond the visible edges.
fn viewport_to_canvas(
viewport_pos: Point,
bounds: Rectangle,
config: &CanvasViewportConfig,
) -> Option<(f32, f32)> {
let display_w = config.engine_w as f32 * config.zoom;
let display_h = config.engine_h as f32 * config.zoom;
@@ -210,13 +260,7 @@ fn viewport_to_canvas(viewport_pos: Point, bounds: Rectangle, config: &CanvasVie
let canvas_x = (viewport_pos.x - origin_x) / config.zoom;
let canvas_y = (viewport_pos.y - origin_y) / config.zoom;
if canvas_x >= 0.0 && canvas_x < config.engine_w as f32
&& canvas_y >= 0.0 && canvas_y < config.engine_h as f32
{
Some((canvas_x, canvas_y))
} else {
None
}
Some((canvas_x, canvas_y))
}
/// Build the canvas viewport widget.
@@ -237,4 +281,4 @@ pub fn canvas_viewport<'a>(
..Default::default()
})
.into()
}
}
@@ -184,9 +184,15 @@ pub fn panel_body<'a>(
app.tool_state.brush_hardness,
app.tool_state.brush_color_variant,
app.tool_state.brush_variant_amount,
app.tool_state.brush_cyclic_color,
app.tool_state.brush_cyclic_speed,
app.tool_state.brush_angle,
app.tool_state.brush_size_variance,
app.tool_state.brush_angle_variance,
app.brush_category,
&app.tool_state.imported_brushes,
app.tool_state.active_brush_preset.as_ref(),
app.fg_color,
colors,
),
PaneType::Filters => crate::panels::filters::view(
@@ -235,6 +241,10 @@ pub fn panel_body<'a>(
app.tool_state.brush_size,
app.tool_state.brush_opacity,
app.tool_state.brush_hardness,
app.tool_state.brush_color_variant,
app.tool_state.brush_variant_amount,
app.tool_state.brush_cyclic_color,
app.tool_state.brush_cyclic_speed,
doc.selection_rect,
doc.vector_draw,
colors,
@@ -1,12 +1,24 @@
//! Brushes panel — brush preset browser with visual thumbnails and live preview.
//! Brushes panel — compact brush preset browser with realistic live preview.
//!
//! Matches the egui version's layout:
//! - Category tabs (All, Drawing, Painting, Watercolor, Effects)
//! - Grid of brush tip thumbnails with visual stroke preview
//! - Selected brush highlighted with accent border
//! - Size/Opacity/Hardness sliders at bottom
//! **Purpose:** Displays the brush library as a compact 3-column grid of
//! realistic brush-stroke thumbnails and renders a live, parameter-aware brush
//! stroke preview at the bottom of the panel. Every preview is produced by the
//! public `hcie_engine_api::Engine::render_brush_preview` path, so the thumbnail
//! and preview pixels match what the brush engine actually draws on the canvas.
//!
//! ⚠️ PERFORMANCE: Brush preview images are cached via OnceLock.
//! **Layout:**
//! - Category tabs (All, Drawing, Painting, Watercolor, Effects, Custom, Imported).
//! - 3-column grid of 36 px stroke thumbnails inside 40 px cells with 8 px labels.
//! - Selected brush highlighted with an accent border.
//! - Live preview area showing the current style, size, opacity, hardness, and
//! foreground color as a short engine-rendered stroke.
//! - Size/Opacity/Hardness sliders, color variant toggle, and variant amount.
//!
//! **Performance:**
//! - Built-in style thumbnails are cached by `BrushStyle` via `OnceLock`.
//! - Media / watercolor / imported preset thumbnails are cached by preset id.
//! - The live stroke preview is cached by a quantized parameter key so it only
//! regenerates when size, opacity, hardness, or foreground color actually change.
use crate::app::Message;
use crate::panels::styles;
@@ -101,9 +113,9 @@ const BRUSH_STYLES: &[BrushStyleEntry] = &[
category: BrushCategory::Drawing,
},
BrushStyleEntry {
name: "Star",
name: "Star Sparkle",
style: BrushStyle::Star,
category: BrushCategory::Drawing,
category: BrushCategory::Effects,
},
BrushStyleEntry {
name: "Oil",
@@ -212,12 +224,78 @@ const BRUSH_STYLES: &[BrushStyleEntry] = &[
},
];
/// Cached brush preview handles keyed by engine style index.
static BRUSH_PREVIEW_CACHE: OnceLock<Mutex<HashMap<usize, iced::widget::image::Handle>>> =
/// Default thumbnail color: neutral light gray so the stroke shape is visible
/// on dark panel backgrounds. Thumbnails intentionally do not use the active
/// foreground color so each brush's visual identity remains stable.
const THUMB_COLOR: [u8; 4] = [200, 200, 200, 255];
/// Cached built-in style stroke preview handles keyed by style index.
///
/// Realistic stroke thumbnails are generated once per style via
/// `Engine::render_brush_preview` and reused for the session.
static STYLE_PREVIEW_CACHE: OnceLock<Mutex<HashMap<usize, iced::widget::image::Handle>>> =
OnceLock::new();
/// Thumbnail size in pixels.
const THUMB_SIZE: u32 = 64;
/// Cached preset stroke preview handles keyed by preset id.
///
/// Media, watercolor, and imported presets each supply their own `BrushTip`; this
/// cache stores the rendered stroke preview keyed by the unique preset id.
static PRESET_PREVIEW_CACHE: OnceLock<Mutex<HashMap<String, iced::widget::image::Handle>>> =
OnceLock::new();
/// Cached live stroke preview handles keyed by the full brush parameter set.
///
/// This cache lets the bottom "Preview" area update in real time as the user
/// changes size, opacity, hardness, or foreground color without re-rendering
/// the same configuration on every frame.
static LIVE_PREVIEW_CACHE: OnceLock<Mutex<HashMap<PreviewKey, iced::widget::image::Handle>>> =
OnceLock::new();
/// Compact thumbnail cell size in pixels.
const THUMB_SIZE: u32 = 40;
/// Image size drawn inside each thumbnail cell.
const THUMB_IMG_SIZE: u32 = 36;
/// Maximum brush size used for thumbnail previews so the full stroke fits.
const THUMB_BRUSH_SIZE: f32 = 16.0;
/// Number of brush thumbnail columns in the grid.
const GRID_COLUMNS: usize = 3;
/// Spacing between grid rows and columns, in logical pixels.
const GRID_SPACING: u16 = 3;
/// Vertical spacing inside a single thumbnail cell (image + label).
const ITEM_SPACING: u16 = 2;
/// Label text size for thumbnail names.
const LABEL_SIZE: u16 = 8;
/// Size of the live stroke preview image at the bottom of the panel.
const LIVE_PREVIEW_IMG_SIZE: u32 = 40;
/// Maximum brush size rendered in the live preview so the stroke character
/// remains visible inside the small preview well even when the user sets a
/// much larger brush for actual painting.
const LIVE_PREVIEW_BRUSH_SIZE: f32 = 22.0;
/// Cache key identifying one unique live brush stroke preview.
///
/// Size, hardness, and opacity are quantized to keep the cache bounded while
/// still capturing the visual changes the user makes in the panel.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
struct PreviewKey {
style_idx: usize,
size: u8,
hardness: u8,
opacity: u8,
cyclic: bool,
r: u8,
g: u8,
b: u8,
a: u8,
}
/// Determines whether a built-in style belongs in the selected category.
///
@@ -290,132 +368,302 @@ fn media_preset_category(category: &str) -> BrushCategory {
}
}
/// Generate a brush stroke preview as RGBA pixels.
/// Build a representative protocol `BrushTip` for a built-in style thumbnail.
///
/// Draws a sine-wave stroke with varying thickness to show the brush characteristics.
fn generate_brush_preview(style: BrushStyle) -> Vec<u8> {
let w = THUMB_SIZE;
let h = THUMB_SIZE;
let mut pixels = vec![0u8; (w * h * 4) as usize];
let n_points = 40;
let mut points = Vec::with_capacity(n_points + 1);
for i in 0..=n_points {
let t = i as f32 / n_points as f32;
let x = 4.0 + t * (w as f32 - 8.0);
let angle = t * std::f32::consts::TAU * 1.25;
let sine = angle.sin();
let taper = (t * (1.0 - t) * 4.0).powf(1.1);
let y = h as f32 / 2.0 + sine * (h as f32 * 0.22) * taper;
points.push((x, y, t));
}
// Color based on style
let color: [u8; 3] = match style {
BrushStyle::Pencil | BrushStyle::Sketch => [180, 180, 180],
BrushStyle::Pen | BrushStyle::InkPen => [40, 40, 40],
BrushStyle::Calligraphy => [60, 40, 30],
BrushStyle::Oil => [180, 120, 60],
BrushStyle::Charcoal => [80, 80, 80],
BrushStyle::Watercolor => [100, 150, 200],
BrushStyle::Crayon => [200, 100, 100],
BrushStyle::Airbrush | BrushStyle::Spray => [120, 120, 120],
BrushStyle::Marker => [60, 120, 60],
BrushStyle::Glow => [200, 200, 100],
BrushStyle::Leaf => [80, 160, 60],
_ => [200, 200, 200],
/// **Purpose:** Each built-in style needs a tip that lets the engine reveal its
/// actual stroke character in a small preview. Size is clamped later to fit
/// the thumbnail so only relative opacity/hardness matter here.
fn thumbnail_tip_for_style(style: BrushStyle) -> hcie_engine_api::BrushTip {
let (size, opacity, hardness) = match style {
BrushStyle::Pencil | BrushStyle::Pen | BrushStyle::InkPen | BrushStyle::Calligraphy => {
(4.0, 0.95, 1.0)
}
BrushStyle::Marker | BrushStyle::Sketch | BrushStyle::Hatch => (6.0, 0.9, 0.85),
BrushStyle::Oil | BrushStyle::Charcoal | BrushStyle::Crayon => (12.0, 0.9, 0.5),
BrushStyle::Watercolor
| BrushStyle::WetPaint
| BrushStyle::Airbrush
| BrushStyle::Spray => (14.0, 0.75, 0.0),
BrushStyle::Leaf
| BrushStyle::Rock
| BrushStyle::Meadow
| BrushStyle::Tree
| BrushStyle::Clouds
| BrushStyle::Dirt
| BrushStyle::Glow
| BrushStyle::Noise
| BrushStyle::Texture => (18.0, 0.9, 0.3),
BrushStyle::Star | BrushStyle::Square | BrushStyle::HardRound => (14.0, 0.95, 1.0),
BrushStyle::SoftRound | BrushStyle::Round | BrushStyle::Default => (14.0, 0.9, 0.5),
BrushStyle::Wood | BrushStyle::Bristle | BrushStyle::Mixer | BrushStyle::Blender => {
(14.0, 0.85, 0.45)
}
BrushStyle::Bitmap => (20.0, 0.9, 0.5),
};
// Draw stroke with varying thickness
for i in 0..n_points {
let (x1, y1, t1) = points[i];
let (x2, y2, _) = points[i + 1];
let thickness = match style {
BrushStyle::Pencil | BrushStyle::Sketch => {
1.0 + 2.0 * (t1 * std::f32::consts::PI).sin().abs()
}
BrushStyle::Pen | BrushStyle::InkPen => {
2.0 + 3.0 * (t1 * std::f32::consts::PI).sin().abs()
}
BrushStyle::Calligraphy => 1.0 + 5.0 * ((t1 * 3.0).sin().abs()),
BrushStyle::Oil | BrushStyle::Charcoal => {
3.0 + 6.0 * (t1 * std::f32::consts::PI).sin().abs()
}
BrushStyle::Watercolor => 2.0 + 4.0 * (t1 * std::f32::consts::PI).sin().abs(),
BrushStyle::Airbrush | BrushStyle::Spray => {
4.0 + 8.0 * (t1 * std::f32::consts::PI).sin().abs()
}
BrushStyle::Glow => 3.0 + 7.0 * (t1 * std::f32::consts::PI).sin().abs(),
_ => 2.0 + 5.0 * (t1 * std::f32::consts::PI).sin().abs(),
};
// Draw line segment with anti-aliasing
let steps = ((thickness * 2.0) as u32).max(1);
for s in 0..steps {
let frac = s as f32 / steps as f32;
let px = x1 + (x2 - x1) * frac;
let py = y1 + (y2 - y1) * frac;
let r = thickness / 2.0;
// Fill circle at (px, py) with radius r
let ix0 = (px - r).max(0.0) as u32;
let iy0 = (py - r).max(0.0) as u32;
let ix1 = (px + r).min(w as f32 - 1.0) as u32;
let iy1 = (py + r).min(h as f32 - 1.0) as u32;
for iy in iy0..=iy1 {
for ix in ix0..=ix1 {
let dx = ix as f32 - px;
let dy = iy as f32 - py;
let dist = (dx * dx + dy * dy).sqrt();
if dist <= r {
let alpha = ((1.0 - dist / r) * 255.0) as u8;
let idx = ((iy * w + ix) * 4) as usize;
// Alpha blend
let src_a = alpha as f32 / 255.0;
let dst_a = pixels[idx + 3] as f32 / 255.0;
let out_a = src_a + dst_a * (1.0 - src_a);
if out_a > 0.0 {
pixels[idx] = ((color[0] as f32 * src_a
+ pixels[idx] as f32 * dst_a * (1.0 - src_a))
/ out_a) as u8;
pixels[idx + 1] = ((color[1] as f32 * src_a
+ pixels[idx + 1] as f32 * dst_a * (1.0 - src_a))
/ out_a) as u8;
pixels[idx + 2] = ((color[2] as f32 * src_a
+ pixels[idx + 2] as f32 * dst_a * (1.0 - src_a))
/ out_a) as u8;
pixels[idx + 3] = (out_a * 255.0) as u8;
}
}
}
}
}
hcie_engine_api::BrushTip {
style,
size,
opacity,
hardness,
..hcie_engine_api::BrushTip::default()
}
pixels
}
/// Get or generate brush preview for a style.
fn get_brush_preview(style: BrushStyle) -> iced::widget::image::Handle {
/// Sample stroke path that fits inside a square preview buffer.
///
/// The path is a short sine wave with pressure rising toward the middle,
/// which is enough to show brush spacing, texture, and tapering behavior.
fn preview_stroke_points(width: u32, height: u32) -> Vec<(f32, f32, f32)> {
let pad = 3.0;
let n = 24;
let mut points = Vec::with_capacity(n);
for i in 0..n {
let t = i as f32 / (n - 1) as f32;
let x = pad + t * (width as f32 - pad * 2.0);
let y =
height as f32 / 2.0 + (t * std::f32::consts::PI * 2.0).sin() * (height as f32 * 0.22);
let pressure = 0.6 + 0.4 * (1.0 - (t - 0.5).abs() * 2.0);
points.push((x, y, pressure));
}
points
}
/// Render a realistic brush stroke preview via the engine.
///
/// **Arguments:**
/// * `width`, `height` — Output buffer dimensions.
/// * `tip` — Protocol `BrushTip` describing the brush to preview.
/// * `color` — RGBA tint for the stroke.
///
/// **Returns:** RGBA pixel buffer produced by `Engine::render_brush_preview`.
/// **Side Effects:** Allocates a temporary engine; none on application state.
fn render_stroke_preview(
width: u32,
height: u32,
tip: &hcie_engine_api::BrushTip,
color: [u8; 4],
) -> Vec<u8> {
let points = preview_stroke_points(width, height);
hcie_engine_api::Engine::render_brush_preview(width, height, tip, color, &points)
}
/// Convert a brush-engine preset tip to the protocol tip used by engine previews.
///
/// `BrushPreset` stores the engine's internal `BrushTip`; the public preview API
/// expects the protocol `BrushTip`. This copies all shared rendering fields.
fn protocol_tip_from_preset(
source: &hcie_engine_api::brush::BrushTip,
) -> hcie_engine_api::BrushTip {
let mut tip = hcie_engine_api::BrushTip::default();
tip.style = preset_style(source.style);
tip.size = source.size;
tip.opacity = source.opacity;
tip.hardness = source.hardness;
tip.spacing = source.spacing;
tip.flow = source.flow;
tip.jitter_amount = source.jitter_amount;
tip.scatter_amount = source.scatter_amount;
tip.angle = source.angle;
tip.roundness = source.roundness;
tip.spray_particle_size = source.spray_particle_size;
tip.spray_density = source.spray_density;
tip.bitmap_pixels = source.bitmap_pixels.clone();
tip.bitmap_w = source.bitmap_w;
tip.bitmap_h = source.bitmap_h;
tip.color_variant = source.color_variant;
tip.variant_amount = source.variant_amount;
tip.density = source.density;
tip.drawing_angle = source.drawing_angle;
tip.rotation_random = source.rotation_random;
tip
}
/// Clamp a tip's size so the preview stroke fits a small thumbnail.
///
/// Hardness is nudged up slightly when shrinking so detail is not lost; opacity
/// and other dynamics are preserved.
fn clamped_preview_tip(
mut tip: hcie_engine_api::BrushTip,
max_size: f32,
) -> hcie_engine_api::BrushTip {
if tip.size > max_size {
let scale = max_size / tip.size;
// Slightly increase hardness as the brush shrinks to keep edges readable.
tip.hardness = (tip.hardness + (1.0 - tip.hardness) * (1.0 - scale)).clamp(0.0, 1.0);
tip.size = max_size;
}
if tip.size < 1.0 {
tip.size = 1.0;
}
tip
}
/// Build a protocol `BrushTip` from the live panel parameters.
///
/// **Purpose:** Feeds the live stroke preview renderer without needing the
/// full `ToolState`. The returned tip captures style, size, opacity, and
/// hardness so the preview matches the next brush stroke.
fn build_tip_from_state(
style: BrushStyle,
size: f32,
opacity: f32,
hardness: f32,
cyclic_color: bool,
angle: f32,
size_variance: f32,
angle_variance: f32,
) -> hcie_engine_api::BrushTip {
hcie_engine_api::BrushTip {
style,
size,
opacity,
hardness,
time_enabled: cyclic_color,
time_size_start: 1.0,
time_size_end: 1.0,
time_opacity_start: 1.0,
time_opacity_end: 1.0,
time_angle_start: 0.0,
time_angle_end: 0.0,
angle,
roundness: size_variance,
rotation_random: angle_variance,
..hcie_engine_api::BrushTip::default()
}
}
/// Quantize preview parameters into a cacheable key.
///
/// **Purpose:** Bound the live preview cache while still updating on every
/// meaningful parameter change made in the panel.
fn preview_key(
style: BrushStyle,
size: f32,
opacity: f32,
hardness: f32,
cyclic: bool,
fg_color: [u8; 4],
) -> PreviewKey {
PreviewKey {
style_idx: style as usize,
size: size.clamp(1.0, 255.0) as u8,
hardness: (hardness * 100.0).clamp(0.0, 100.0) as u8,
opacity: (opacity * 100.0).clamp(0.0, 100.0) as u8,
cyclic,
r: fg_color[0],
g: fg_color[1],
b: fg_color[2],
a: fg_color[3],
}
}
/// Get or generate a live brush stroke preview for the current tool state.
///
/// **Purpose:** Renders a short engine-drawn stroke that reflects the active
/// style, size, opacity, hardness, and foreground color.
///
/// **Logic & Workflow:**
/// 1. Build a cache key from quantized parameters.
/// 2. Return a cached `image::Handle` if the same configuration was rendered
/// earlier in this session.
/// 3. Otherwise, build a `BrushTip`, ask the engine to render a stroke preview,
/// store the handle, and return it.
///
/// **Arguments:** See `build_tip_from_state` plus `fg_color`, the RGBA tint.
///
/// **Returns:** An Iced image handle sized `LIVE_PREVIEW_IMG_SIZE` square.
/// **Side Effects:** Populates `LIVE_PREVIEW_CACHE`.
fn get_live_stroke_preview(
style: BrushStyle,
size: f32,
opacity: f32,
hardness: f32,
cyclic_color: bool,
fg_color: [u8; 4],
angle: f32,
size_variance: f32,
angle_variance: f32,
) -> iced::widget::image::Handle {
// Clamp the rendered brush size so a 110 px soft brush does not fill the
// entire 40 px preview well with a solid blob. The preview shows texture and
// stroke character; the slider still reports the real painting size.
let preview_size = size.clamp(4.0, LIVE_PREVIEW_BRUSH_SIZE);
let key = preview_key(style, preview_size, opacity, hardness, cyclic_color, fg_color);
let cache = LIVE_PREVIEW_CACHE.get_or_init(|| Mutex::new(HashMap::new()));
let mut cache = cache
.lock()
.unwrap_or_else(|poisoned| poisoned.into_inner());
if let Some(handle) = cache.get(&key) {
return handle.clone();
}
let tip = build_tip_from_state(
style,
preview_size,
opacity,
hardness,
cyclic_color,
angle,
size_variance,
angle_variance,
);
let pixels =
render_stroke_preview(LIVE_PREVIEW_IMG_SIZE, LIVE_PREVIEW_IMG_SIZE, &tip, fg_color);
let handle = iced::widget::image::Handle::from_rgba(
LIVE_PREVIEW_IMG_SIZE,
LIVE_PREVIEW_IMG_SIZE,
pixels,
);
cache.insert(key, handle.clone());
handle
}
/// Clamp a cyclic speed value to the engine's valid range.
fn clamp_cyclic_speed(speed: f32) -> f32 {
speed.clamp(0.01, 5.0)
}
/// Get or generate a realistic stroke preview for a built-in brush style.
///
/// **Purpose:** Provides the thumbnails shown in the built-in style grid. The
/// preview is rendered through the engine so the stroke matches what the user
/// actually paints with that style.
fn get_style_preview(style: BrushStyle) -> iced::widget::image::Handle {
let style_idx = style as usize;
let cache = BRUSH_PREVIEW_CACHE.get_or_init(|| Mutex::new(HashMap::new()));
let cache = STYLE_PREVIEW_CACHE.get_or_init(|| Mutex::new(HashMap::new()));
let mut cache = cache
.lock()
.unwrap_or_else(|poisoned| poisoned.into_inner());
if let Some(handle) = cache.get(&style_idx) {
return handle.clone();
}
let handle = iced::widget::image::Handle::from_rgba(
THUMB_SIZE,
THUMB_SIZE,
generate_brush_preview(style),
);
let tip = clamped_preview_tip(thumbnail_tip_for_style(style), THUMB_BRUSH_SIZE);
let pixels = render_stroke_preview(THUMB_SIZE, THUMB_SIZE, &tip, THUMB_COLOR);
let handle = iced::widget::image::Handle::from_rgba(THUMB_SIZE, THUMB_SIZE, pixels);
cache.insert(style_idx, handle.clone());
handle
}
/// Get or generate a realistic stroke preview for a runtime brush preset.
///
/// **Purpose:** Provides the thumbnails shown for media, watercolor, and
/// imported presets. The preset's own `BrushTip` is used so the preview reflects
/// the preset's size, hardness, opacity, density, and other dynamics.
fn get_preset_preview(preset: &hcie_engine_api::BrushPreset) -> iced::widget::image::Handle {
let cache = PRESET_PREVIEW_CACHE.get_or_init(|| Mutex::new(HashMap::new()));
let mut cache = cache
.lock()
.unwrap_or_else(|poisoned| poisoned.into_inner());
if let Some(handle) = cache.get(&preset.id) {
return handle.clone();
}
let tip = clamped_preview_tip(protocol_tip_from_preset(&preset.tip), THUMB_BRUSH_SIZE);
let pixels = render_stroke_preview(THUMB_SIZE, THUMB_SIZE, &tip, THUMB_COLOR);
let handle = iced::widget::image::Handle::from_rgba(THUMB_SIZE, THUMB_SIZE, pixels);
cache.insert(preset.id.clone(), handle.clone());
handle
}
/// Build the brushes panel with visual thumbnails.
pub fn view(
current_style: BrushStyle,
@@ -424,9 +672,15 @@ pub fn view(
current_hardness: f32,
brush_color_variant: bool,
brush_variant_amount: f32,
brush_cyclic_color: bool,
brush_cyclic_speed: f32,
brush_angle: f32,
brush_size_variance: f32,
brush_angle_variance: f32,
active_category: BrushCategory,
imported_presets: &[hcie_engine_api::BrushPreset],
active_brush_preset: Option<&hcie_engine_api::BrushPreset>,
fg_color: [u8; 4],
colors: ThemeColors,
) -> Element<'static, Message> {
// Category tabs
@@ -500,9 +754,9 @@ pub fn view(
));
}
// Brush preset grid — two columns remain usable in narrow dock panes.
let mut grid_rows = column![].spacing(4);
let mut current_row = row![].spacing(4);
// Brush preset grid — three compact columns fit comfortably in narrow dock panes.
let mut grid_rows = column![].spacing(GRID_SPACING);
let mut current_row = row![].spacing(GRID_SPACING);
let filtered_styles: Vec<&BrushStyleEntry> = BRUSH_STYLES
.iter()
@@ -511,23 +765,27 @@ pub fn view(
for (idx, preset) in filtered_styles.iter().enumerate() {
let is_selected = preset.style == current_style;
let preview = get_brush_preview(preset.style);
let preview = get_style_preview(preset.style);
let c = colors;
let style = preset.style;
let thumb = container(iced::widget::image(preview).width(48).height(48))
.width(56)
.height(56)
.center_x(48)
.center_y(48)
.style(move |_theme| styles::raised_card(c, is_selected));
let thumb = container(
iced::widget::image(preview)
.width(THUMB_IMG_SIZE as f32)
.height(THUMB_IMG_SIZE as f32),
)
.width(THUMB_SIZE as f32)
.height(THUMB_SIZE as f32)
.align_x(iced::alignment::Horizontal::Center)
.align_y(iced::alignment::Vertical::Center)
.style(move |_theme| styles::raised_card(c, is_selected));
let label = container(text(preset.name).size(9))
let label = container(text(preset.name).size(LABEL_SIZE))
.width(Length::Fill)
.center_x(Length::Fill);
.align_x(iced::alignment::Horizontal::Center);
let cell = column![thumb, label]
.spacing(2)
.spacing(ITEM_SPACING)
.align_x(iced::Alignment::Center);
let clickable = button(cell)
@@ -554,54 +812,44 @@ pub fn view(
current_row = current_row.push(clickable);
if (idx + 1) % 2 == 0 || idx == filtered_styles.len() - 1 {
if (idx + 1) % GRID_COLUMNS == 0 || idx == filtered_styles.len() - 1 {
grid_rows = grid_rows.push(current_row);
current_row = row![].spacing(4);
current_row = row![].spacing(GRID_SPACING);
}
}
// ── Watercolor presets (from hcie-watercolor-brushes crate) ───────────
let mut wc_rows = column![].spacing(4);
let mut wc_rows = column![].spacing(GRID_SPACING);
if matches!(
active_category,
BrushCategory::All | BrushCategory::Watercolor
) {
let wc_presets = hcie_watercolor_brushes::watercolor_presets();
let mut wc_row = row![].spacing(4);
let mut wc_row = row![].spacing(GRID_SPACING);
for (idx, preset) in wc_presets.iter().enumerate() {
let is_selected = preset_style(preset.style) == current_style
&& active_brush_preset
.as_ref()
.map_or(false, |p| p.id == preset.id);
let c = colors;
let wc_color: [u8; 3] = match preset.id.as_str() {
"wc_wash" => [100, 150, 200],
"wc_wet" => [80, 130, 190],
"wc_dry" => [140, 110, 80],
"wc_glaze" => [120, 160, 210],
"wc_splat" => [90, 140, 180],
"wc_bleed" => [110, 80, 150],
"wc_grain" => [130, 120, 100],
"wc_bloom" => [90, 170, 200],
_ => [100, 150, 200],
};
let splat_pixels =
hcie_watercolor_brushes::render_watercolor_splat(preset.style, wc_color);
let preview =
iced::widget::image::Handle::from_rgba(THUMB_SIZE, THUMB_SIZE, splat_pixels);
let thumb = container(iced::widget::image(preview).width(48).height(48))
.width(56)
.height(56)
.center_x(48)
.center_y(48)
.style(move |_theme| styles::raised_card(c, is_selected));
let preview = get_preset_preview(preset);
let thumb = container(
iced::widget::image(preview)
.width(THUMB_IMG_SIZE as f32)
.height(THUMB_IMG_SIZE as f32),
)
.width(THUMB_SIZE as f32)
.height(THUMB_SIZE as f32)
.align_x(iced::alignment::Horizontal::Center)
.align_y(iced::alignment::Vertical::Center)
.style(move |_theme| styles::raised_card(c, is_selected));
let label = container(text(preset.name.clone()).size(9))
let label = container(text(preset.name.clone()).size(LABEL_SIZE))
.width(Length::Fill)
.center_x(Length::Fill);
.align_x(iced::alignment::Horizontal::Center);
let cell = column![thumb, label]
.spacing(2)
.spacing(ITEM_SPACING)
.align_x(iced::Alignment::Center);
let preset_msg = preset.clone();
@@ -629,9 +877,9 @@ pub fn view(
wc_row = wc_row.push(clickable);
if (idx + 1) % 2 == 0 || idx == wc_presets.len() - 1 {
if (idx + 1) % GRID_COLUMNS == 0 || idx == wc_presets.len() - 1 {
wc_rows = wc_rows.push(wc_row);
wc_row = row![].spacing(4);
wc_row = row![].spacing(GRID_SPACING);
}
}
}
@@ -649,27 +897,31 @@ pub fn view(
|| active_category == media_preset_category(&preset.category)
})
.collect();
let mut media_rows = column![].spacing(4);
let mut media_row = row![].spacing(4);
let mut media_rows = column![].spacing(GRID_SPACING);
let mut media_row = row![].spacing(GRID_SPACING);
for (idx, preset) in filtered_media.iter().enumerate() {
let style = preset_style(preset.style);
let selected = style == current_style
&& active_brush_preset.is_some_and(|active| active.id == preset.id);
let preview = get_brush_preview(style);
let preview = get_preset_preview(preset);
let preset_message = preset.clone();
let c = colors;
let cell = column![
container(iced::widget::image(preview).width(48).height(48))
.width(56)
.height(56)
.center_x(48)
.center_y(48)
.style(move |_theme| styles::raised_card(c, selected)),
container(text(preset.name.clone()).size(9))
container(
iced::widget::image(preview)
.width(THUMB_IMG_SIZE as f32)
.height(THUMB_IMG_SIZE as f32)
)
.width(THUMB_SIZE as f32)
.height(THUMB_SIZE as f32)
.align_x(iced::alignment::Horizontal::Center)
.align_y(iced::alignment::Vertical::Center)
.style(move |_theme| styles::raised_card(c, selected)),
container(text(preset.name.clone()).size(LABEL_SIZE))
.width(Length::Fill)
.center_x(Length::Fill),
.align_x(iced::alignment::Horizontal::Center),
]
.spacing(2)
.spacing(ITEM_SPACING)
.align_x(iced::Alignment::Center);
media_row = media_row.push(
button(cell)
@@ -688,13 +940,13 @@ pub fn view(
..Default::default()
}),
);
if (idx + 1) % 2 == 0 || idx == filtered_media.len() - 1 {
if (idx + 1) % GRID_COLUMNS == 0 || idx == filtered_media.len() - 1 {
media_rows = media_rows.push(media_row);
media_row = row![].spacing(4);
media_row = row![].spacing(GRID_SPACING);
}
}
let mut imported_rows = column![].spacing(3);
let mut imported_rows = column![].spacing(GRID_SPACING);
if matches!(
active_category,
BrushCategory::All | BrushCategory::Imported
@@ -703,19 +955,25 @@ pub fn view(
let style = preset_style(preset.style);
let selected = style == current_style;
let preset_message = preset.clone();
let preview = get_brush_preview(style);
let preview = get_preset_preview(preset);
let name = preset.name.clone();
imported_rows = imported_rows.push(
button(
row![
container(iced::widget::image(preview).width(42).height(24))
.width(48)
.height(28)
.center_x(Length::Fill)
.center_y(Length::Fill),
container(
iced::widget::image(preview)
.width(THUMB_IMG_SIZE as f32)
.height(THUMB_IMG_SIZE as f32)
)
.width(THUMB_SIZE as f32)
.height(THUMB_SIZE as f32)
.align_x(iced::alignment::Horizontal::Center)
.align_y(iced::alignment::Vertical::Center),
column![
text(name).size(10),
text("Imported ABR").size(8).color(colors.text_secondary),
text(name).size(LABEL_SIZE + 1),
text("Imported ABR")
.size(LABEL_SIZE)
.color(colors.text_secondary),
]
.spacing(1),
]
@@ -724,7 +982,7 @@ pub fn view(
)
.on_press(Message::BrushPresetSelected(preset_message))
.width(Length::Fill)
.padding(3)
.padding(2)
.style(move |_theme, status| iced::widget::button::Style {
background: Some(iced::Background::Color(if selected {
colors.bg_active
@@ -803,31 +1061,121 @@ pub fn view(
colors,
Message::BrushVariantAmountChanged,
);
let cyclic_speed_slider = plain_slider(
"Cyclic Speed",
clamp_cyclic_speed(brush_cyclic_speed),
0.01..=5.0,
0.01,
"x",
2,
colors,
Message::BrushCyclicSpeedChanged,
);
let color_variant_check = checkbox("Color variant", brush_color_variant)
.on_toggle(Message::BrushColorVariantToggled)
.size(16)
.spacing(6);
let is_star = current_style == BrushStyle::Star;
let star_angle_slider = if is_star {
Some(plain_slider(
"Star Angle",
brush_angle,
0.0..=std::f32::consts::TAU,
0.01,
"rad",
2,
colors,
Message::BrushAngleChanged,
))
} else {
None
};
let star_size_var_slider = if is_star {
Some(plain_slider(
"Size Variance",
brush_size_variance,
0.0..=1.0,
0.01,
"%",
0,
colors,
Message::BrushSizeVarianceChanged,
))
} else {
None
};
let star_angle_var_slider = if is_star {
Some(plain_slider(
"Angle Variance",
brush_angle_variance,
0.0..=1.0,
0.01,
"%",
0,
colors,
Message::BrushAngleVarianceChanged,
))
} else {
None
};
// Live preview — show current brush tip
let preview_handle = get_brush_preview(current_style);
let live_preview = container(iced::widget::image(preview_handle).width(64).height(64))
.width(Length::Fill)
.height(80)
.center_x(Length::Fill)
.center_y(Length::Fill)
.style(move |_theme| styles::recessed_control(colors));
// Compact color-variant toggle: an empty 12 px checkbox plus an 8 px label so
// the control matches the rest of the compact panel typography.
let color_variant_check = row![
checkbox("", brush_color_variant)
.on_toggle(Message::BrushColorVariantToggled)
.size(12),
text("Color variant").size(LABEL_SIZE),
]
.spacing(4)
.align_y(iced::Alignment::Center);
let cyclic_color_check = row![
checkbox("", brush_cyclic_color)
.on_toggle(Message::BrushCyclicColorToggled)
.size(12),
text("Cyclic color").size(LABEL_SIZE),
]
.spacing(4)
.align_y(iced::Alignment::Center);
// Live preview — show a realistic engine-rendered stroke using the active
// size, opacity, hardness, and foreground color. The preview is
// parameter-keyed and cached so it updates in real time without
// re-rendering identical configurations.
let preview_handle = get_live_stroke_preview(
current_style,
current_size,
current_opacity,
current_hardness,
brush_cyclic_color,
fg_color,
brush_angle,
brush_size_variance,
brush_angle_variance,
);
let live_preview = container(
iced::widget::image(preview_handle)
.width(LIVE_PREVIEW_IMG_SIZE as f32)
.height(LIVE_PREVIEW_IMG_SIZE as f32),
)
.width(Length::Fill)
.height(56)
.align_x(iced::alignment::Horizontal::Center)
.align_y(iced::alignment::Vertical::Center)
.style(move |_theme| styles::recessed_control(colors));
// Panel title is in the dock tab — no duplicate inside the panel.
let panel = column![
tabs,
horizontal_rule(1),
scrollable(column![grid_rows, wc_rows, media_rows, imported_rows].spacing(6))
.height(Length::Fill),
horizontal_rule(1),
row![button(text("Import ABR").size(10))
let mut panel_children: Vec<Element<'static, Message>> = vec![
tabs.into(),
horizontal_rule(1).into(),
scrollable(column![grid_rows, wc_rows, media_rows, imported_rows].spacing(GRID_SPACING))
.height(Length::Fill)
.into(),
horizontal_rule(1).into(),
];
panel_children.push(
row![button(text("Import ABR").size(LABEL_SIZE))
.on_press(Message::BrushImportAbr)
.padding([4, 8])
.padding([3, 7])
.style(
move |_theme: &iced::Theme, status: iced::widget::button::Status| {
match status {
@@ -846,17 +1194,31 @@ pub fn view(
}
}
)]
.spacing(4),
text("Preview").size(10),
live_preview,
size_slider,
opacity_slider,
hardness_slider,
color_variant_check,
variant_slider,
]
.spacing(2)
.padding(4);
.spacing(GRID_SPACING)
.into(),
);
panel_children.push(text("Preview").size(LABEL_SIZE + 1).into());
panel_children.push(live_preview.into());
panel_children.push(size_slider.into());
panel_children.push(opacity_slider.into());
panel_children.push(hardness_slider.into());
panel_children.push(color_variant_check.into());
panel_children.push(variant_slider.into());
panel_children.push(cyclic_color_check.into());
panel_children.push(cyclic_speed_slider.into());
if let Some(s) = star_angle_slider {
panel_children.push(s.into());
}
if let Some(s) = star_size_var_slider {
panel_children.push(s.into());
}
if let Some(s) = star_angle_var_slider {
panel_children.push(s.into());
}
let panel = iced::widget::Column::with_children(panel_children)
.spacing(ITEM_SPACING)
.padding(3);
container(panel)
.width(Length::Fill)
@@ -903,7 +1265,7 @@ mod tests {
presets.extend(hcie_paint_brushes::paint_presets());
presets.extend(hcie_digital_brushes::digital_presets());
presets.extend(hcie_watercolor_brushes::watercolor_presets());
assert_eq!(presets.len(), 47);
assert_eq!(presets.len(), 48);
assert_eq!(
presets
.iter()
@@ -93,6 +93,10 @@ pub fn view<'a>(
brush_size: f32,
brush_opacity: f32,
brush_hardness: f32,
brush_color_variant: bool,
brush_variant_amount: f32,
brush_cyclic_color: bool,
brush_cyclic_speed: f32,
selection_rect: Option<(f32, f32, f32, f32)>,
vector_draw: Option<((f32, f32), (f32, f32))>,
colors: ThemeColors,
@@ -134,12 +138,25 @@ pub fn view<'a>(
// Build tool/shape-specific section
let tool_section: Element<'a, Message> = match active_tool {
Tool::Pen | Tool::Brush | Tool::Eraser => {
brush_properties(brush_size, brush_opacity, brush_hardness, colors)
brush_properties(
brush_size,
brush_opacity,
brush_hardness,
brush_color_variant,
brush_variant_amount,
brush_cyclic_color,
brush_cyclic_speed,
colors,
)
}
Tool::Spray => spray_properties(
brush_size,
brush_opacity,
brush_hardness,
brush_color_variant,
brush_variant_amount,
brush_cyclic_color,
brush_cyclic_speed,
settings_spray_particle_size,
settings_spray_density,
colors,
@@ -511,11 +528,20 @@ fn vector_tool_properties<'a>(
col.into()
}
/// Shared cyclic speed clamp used by brush and spray property sections.
fn clamp_cyclic_speed(speed: f32) -> f32 {
speed.clamp(0.01, 5.0)
}
/// Brush tool properties (Pen, Brush, Eraser).
fn brush_properties<'a>(
size: f32,
opacity: f32,
hardness: f32,
color_variant: bool,
variant_amount: f32,
cyclic_color: bool,
cyclic_speed: f32,
colors: ThemeColors,
) -> Element<'a, Message> {
column![
@@ -529,6 +555,40 @@ fn brush_properties<'a>(
plain_slider("Hardness", hardness, 0.0..=1.0, 0.01, "%", 0, colors, |v| {
Message::BrushHardnessChanged(v)
},),
row![
checkbox("Color Variant", color_variant)
.on_toggle(Message::BrushColorVariantToggled)
.size(11),
]
.spacing(4)
.align_y(iced::Alignment::Center),
plain_slider(
"Variant Amount",
variant_amount,
0.0..=1.0,
0.01,
"%",
0,
colors,
Message::BrushVariantAmountChanged,
),
row![
checkbox("Cyclic Color", cyclic_color)
.on_toggle(Message::BrushCyclicColorToggled)
.size(11),
]
.spacing(4)
.align_y(iced::Alignment::Center),
plain_slider(
"Cyclic Speed",
clamp_cyclic_speed(cyclic_speed),
0.01..=5.0,
0.01,
"x",
2,
colors,
Message::BrushCyclicSpeedChanged,
),
]
.spacing(4)
.into()
@@ -539,6 +599,10 @@ fn spray_properties<'a>(
size: f32,
opacity: f32,
hardness: f32,
color_variant: bool,
variant_amount: f32,
cyclic_color: bool,
cyclic_speed: f32,
particle_size: f32,
density: u32,
colors: ThemeColors,
@@ -574,6 +638,40 @@ fn spray_properties<'a>(
plain_slider("Hardness", hardness, 0.0..=1.0, 0.01, "%", 0, colors, |v| {
Message::BrushHardnessChanged(v)
},),
row![
checkbox("Color Variant", color_variant)
.on_toggle(Message::BrushColorVariantToggled)
.size(11),
]
.spacing(4)
.align_y(iced::Alignment::Center),
plain_slider(
"Variant Amount",
variant_amount,
0.0..=1.0,
0.01,
"%",
0,
colors,
Message::BrushVariantAmountChanged,
),
row![
checkbox("Cyclic Color", cyclic_color)
.on_toggle(Message::BrushCyclicColorToggled)
.size(11),
]
.spacing(4)
.align_y(iced::Alignment::Center),
plain_slider(
"Cyclic Speed",
clamp_cyclic_speed(cyclic_speed),
0.01..=5.0,
0.01,
"x",
2,
colors,
Message::BrushCyclicSpeedChanged,
),
]
.spacing(4)
.into()
@@ -134,6 +134,17 @@ fn brush_settings(
|v| Message::BrushVariantAmountChanged(v / 100.0),
c
),
checkbox("Cyclic Color", ts.brush_cyclic_color)
.on_toggle(Message::BrushCyclicColorToggled)
.size(11),
prop_slider(
"Cyclic Speed",
ts.brush_cyclic_speed.clamp(0.01, 5.0),
0.01,
5.0,
Message::BrushCyclicSpeedChanged,
c
),
]
.spacing(4)
}
@@ -186,6 +197,28 @@ fn spray_settings(
|v| Message::BrushHardnessChanged(v / 100.0),
c
),
checkbox("Color Variant", ts.brush_color_variant)
.on_toggle(Message::BrushColorVariantToggled)
.size(11),
prop_slider(
"Variant Amount",
ts.brush_variant_amount * 100.0,
0.0,
100.0,
|v| Message::BrushVariantAmountChanged(v / 100.0),
c
),
checkbox("Cyclic Color", ts.brush_cyclic_color)
.on_toggle(Message::BrushCyclicColorToggled)
.size(11),
prop_slider(
"Cyclic Speed",
ts.brush_cyclic_speed.clamp(0.01, 5.0),
0.01,
5.0,
Message::BrushCyclicSpeedChanged,
c
),
]
.spacing(4)
}
@@ -59,6 +59,21 @@ pub struct ToolSettings {
/// Magnitude of the per-dab color variation (0.0..1.0).
#[serde(default)]
pub brush_variant_amount: f32,
/// Star brush base rotation angle in radians.
#[serde(default)]
pub brush_angle: f32,
/// Star brush per-dab size variance (0.0..1.0).
#[serde(default)]
pub brush_size_variance: f32,
/// Star brush per-dab angle variance (0.0..1.0).
#[serde(default)]
pub brush_angle_variance: f32,
/// True when the brush color should cycle through the hue over stroke distance.
#[serde(default)]
pub brush_cyclic_color: bool,
/// Speed of the hue cycle along the stroke (0.01..5.0).
#[serde(default)]
pub brush_cyclic_speed: f32,
pub eraser_size: f32,
pub eraser_opacity: f32,
pub pen_size: f32,
@@ -192,6 +207,11 @@ impl Default for ToolSettings {
brush_spacing: 1.0,
brush_color_variant: false,
brush_variant_amount: 0.0,
brush_angle: 0.0,
brush_size_variance: 0.0,
brush_angle_variance: 0.0,
brush_cyclic_color: false,
brush_cyclic_speed: 0.5,
eraser_size: 20.0,
eraser_opacity: 1.0,
pen_size: 2.0,
@@ -344,6 +364,11 @@ impl AppSettings {
self.tool_settings.brush_hardness = tool_state.brush_hardness;
self.tool_settings.brush_color_variant = tool_state.brush_color_variant;
self.tool_settings.brush_variant_amount = tool_state.brush_variant_amount;
self.tool_settings.brush_angle = tool_state.brush_angle;
self.tool_settings.brush_size_variance = tool_state.brush_size_variance;
self.tool_settings.brush_angle_variance = tool_state.brush_angle_variance;
self.tool_settings.brush_cyclic_color = tool_state.brush_cyclic_color;
self.tool_settings.brush_cyclic_speed = tool_state.brush_cyclic_speed;
self.tool_settings.last_active_tool = format!("{:?}", tool_state.active_tool);
}
@@ -354,6 +379,11 @@ impl AppSettings {
tool_state.brush_hardness = self.tool_settings.brush_hardness;
tool_state.brush_color_variant = self.tool_settings.brush_color_variant;
tool_state.brush_variant_amount = self.tool_settings.brush_variant_amount;
tool_state.brush_angle = self.tool_settings.brush_angle;
tool_state.brush_size_variance = self.tool_settings.brush_size_variance;
tool_state.brush_angle_variance = self.tool_settings.brush_angle_variance;
tool_state.brush_cyclic_color = self.tool_settings.brush_cyclic_color;
tool_state.brush_cyclic_speed = self.tool_settings.brush_cyclic_speed;
}
}